Skip to content

fix: liger unnecessarily materializes logits in VRAM during eval, causing OOM - #45273

Merged
SunMarc merged 2 commits into
huggingface:mainfrom
excepshenal:excepshenal-fix-liger-eval-oom
Jul 22, 2026
Merged

SunMarc merged 2 commits into
huggingface:mainfrom
excepshenal:excepshenal-fix-liger-eval-oom

Conversation

@excepshenal

@excepshenal excepshenal commented Apr 6, 2026 •

Copy link
Copy Markdown
Contributor

CI

What does this PR do?

Liger kernel unnecessarily materializes logits in VRAM during eval with prediction_loss_only=True, causing OOM. We explicitly tell Liger to skip_logits.

Code Agent Policy

The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.

PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.

This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read CONTRIBUTING.md.

  • I confirm that this is not a pure code agent PR.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?
    No, but I used this in my own training setup and observed the fix.

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45273&sha=480240

@Rocketknight1

Copy link
Copy Markdown
Member

cc @SunMarc but not sure trainer is the place for this?

@SunMarc

SunMarc commented Apr 9, 2026 •

Copy link
Copy Markdown
Member

I think we can add it, there were another PR that also wanted to have this. #44981. I'll probably merge the other one as it was there before

@originalgremlin

Copy link
Copy Markdown

is there any intention to merge this PR? or 44981? i've been maintaining a patched version of transformers using liger on dozens of models and haven't had any problems. would be better to stop maintaining that patch and use the official version directly, though.

@SunMarc SunMarc left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! I will merge this one then @originalgremlin

@SunMarc
SunMarc enabled auto-merge July 21, 2026 15:39
@github-actions

Copy link
Copy Markdown
Contributor

CI recap

Dashboard: View test results in Grafana
Latest run: 29845018072
Result: success | Grafana metrics are not available yet.

@SunMarc
SunMarc added this pull request to the merge queue Jul 22, 2026
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Merged via the queue into huggingface:main with commit 0dad545 Jul 22, 2026
106 checks passed
stevhliu pushed a commit to stevhliu/transformers that referenced this pull request Jul 30, 2026
…sing OOM (huggingface#45273)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
Sainava pushed a commit to Sainava/Sai-transformers that referenced this pull request Aug 3, 2026
…sing OOM (huggingface#45273)

Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants