Repository navigation
fix: liger unnecessarily materializes logits in VRAM during eval, causing OOM - #45273
Conversation
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45273&sha=480240 |
|
cc @SunMarc but not sure trainer is the place for this? |
|
I think we can add it, there were another PR that also wanted to have this. #44981. I'll probably merge the other one as it was there before |
|
is there any intention to merge this PR? or 44981? i've been maintaining a patched version of transformers using liger on dozens of models and haven't had any problems. would be better to stop maintaining that patch and use the official version directly, though. |
There was a problem hiding this comment.
Thanks ! I will merge this one then @originalgremlin
CI recapDashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…sing OOM (huggingface#45273) Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
…sing OOM (huggingface#45273) Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
What does this PR do?
Liger kernel unnecessarily materializes logits in VRAM during eval with
prediction_loss_only=True, causing OOM. We explicitly tell Liger toskip_logits.Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
No, but I used this in my own training setup and observed the fix.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.