Repository navigation
fix(tokenizer): Fix MLukeTokenizer AttributeError post-v5 refactor - #44362
Merged
Rocketknight1 merged 2 commits intoMar 2, 2026
Merged
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: mluke |
harshaljanjani
marked this pull request as ready for review
February 28, 2026 20:09
Member
|
Yeah, this looks like it was just missed in the migration. Thank you! |
Rocketknight1
approved these changes
Mar 2, 2026
Rocketknight1
enabled auto-merge (squash)
March 2, 2026 14:42
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following failing Dia use case was identified and fixed in this PR:
→ MIGRATION_GUIDE_V5.md states that v5 renamed
additional_special_tokenstoextra_special_tokensinternally as part of the tokenizer refactor; but tokenization_mluke.py (amongst other instances) still referencesself.additional_special_tokens_ids, which is the only remaining call site under the old name that needs fixing :)→ For more details on reproducing the bug and the output screenshots, please visit the linked issue!
Fixes #44361.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.