Repository navigation
Move missing weights and non-persistent buffers to correct device earlier - #43021
Merged
Merged
Conversation
Cyrilvallez
commented
Dec 23, 2025
Comment on lines
+4340
to
+4342
| # This is the only case where we do not initialize the model on meta device, so we don't have to do anything here | ||
| if is_deepspeed_zero3_enabled() and not is_quantized: | ||
| return |
Member
Author
There was a problem hiding this comment.
cc @SunMarc, could you make extra sure that simply doing this is enough? It should be as it's technically useless to reset the internal param, as it was not on meta before anyway - but let's make sure as you made that change yesterday
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43021&sha=a75715 |
SunMarc
approved these changes
Dec 23, 2025
SunMarc
left a comment
SunMarc
left a comment
Member
There was a problem hiding this comment.
Nice, thanks ! This is much better
RatStar811
approved these changes
Dec 29, 2025
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…lier (huggingface#43021) * move to correct device earlier * fix typo * simplify
1 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. Better to send everthing directly to the correct device, rather than cpu, then initialize, then move to device