Skip to content

Fix collated reports model directory traversal #40437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivarflakstad merged 1 commit into from
Aug 25, 2025
Merged

Fix collated reports model directory traversal #40437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions utils/collated_reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,13 @@ def upload_collated_report(job: str, report_repo_id: str, filename: str):
job = args.job
report_repo_id = args.report_repo_id

# Find the origin directory based on machine type
origin = path
for p in path.iterdir():
if machine_type in p.name:
origin = p
break

# Loop through model directories and create collated reports
for model_dir in sorted(origin.iterdir()):
for model_dir in sorted(path.iterdir()):
if not model_dir.name.startswith(machine_type):
continue

# Create a new entry for the model
model_name = model_dir.name.removesuffix("_test_reports")
model_name = model_dir.name.removeprefix(machine_type).removesuffix("_test_reports")
report = {"model": model_name, "results": []}
results = []

Expand Down