Skip to content

Enable multi-device for Segformer - #33108

Closed
Nech-C wants to merge 1 commit into
huggingface:mainfrom
Nech-C:enabling_segformer_multidevice
Closed

Nech-C wants to merge 1 commit into
huggingface:mainfrom
Nech-C:enabling_segformer_multidevice

Conversation

@Nech-C

@Nech-C Nech-C commented Aug 24, 2024

Copy link
Copy Markdown

What does this PR do?

Fixes #29786 (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

@asartran

asartran commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

As discussed here, waiting for wider discussion about weight allocation from accelerate, as segformer will never be correctly split across devices due to highly imbalance sizes of different model modules

@ArthurZucker

Copy link
Copy Markdown
Collaborator

Thanks a lot for the PR! This was superseded by #41693, which landed on main and covers the same change, so closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Community contribution: enabling device_map="auto" support for more vision and multimodal models

3 participants