Skip to content

Unpin protobuf in docker file (for daily CI) - #24761

Merged
ydshieh merged 1 commit into
mainfrom
unpin_protobuf_in_docker_file
Jul 11, 2023
Merged

ydshieh merged 1 commit into
mainfrom
unpin_protobuf_in_docker_file

Conversation

@ydshieh

@ydshieh ydshieh commented Jul 11, 2023

Copy link
Copy Markdown
Collaborator

What does this PR do?

I forgot to unpin protobuf (in the docker file) in my previous PR #24599.

Currently, CircleCI is testing against with protobuf 4, but daily CI is still v3. Let's move on on daily CI too.

@ydshieh
ydshieh requested a review from sgugger July 11, 2023 21:25
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jul 11, 2023 •

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ydshieh
ydshieh merged commit 45025d9 into main Jul 11, 2023
@ydshieh
ydshieh deleted the unpin_protobuf_in_docker_file branch July 11, 2023 21:55
ydshieh added a commit that referenced this pull request Jul 13, 2023
ydshieh added a commit that referenced this pull request Jul 13, 2023
Revert "Unpin protobuf in docker file (for daily CI) (#24761)"

This reverts commit 45025d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants