Skip to content

🌐 [i18n-KO] translate create_a_model doc to Korean - #22754

Merged
sgugger merged 1 commit into
huggingface:mainfrom
gabrielwithappy:ko-custom_arch
Apr 24, 2023
Merged

sgugger merged 1 commit into
huggingface:mainfrom
gabrielwithappy:ko-custom_arch

Conversation

@gabrielwithappy

@gabrielwithappy gabrielwithappy commented Apr 14, 2023 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the create_a_model.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 16, 2023 •

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@gabrielwithappy

Copy link
Copy Markdown
Contributor Author

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

@sim-so sim-so left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 작업이 점점 빨라지고 있네요!
몇 가지 수정 제안을 드립니다 😄

Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
Comment thread docs/source/ko/create_a_model.mdx Resolved
@gabrielwithappy

Copy link
Copy Markdown
Contributor Author

리뷰 해주신 내용 확인했습니다.
확인해보고 다시 업데이트 할께요~

@gabrielwithappy
gabrielwithappy marked this pull request as ready for review April 24, 2023 13:28
@gabrielwithappy

Copy link
Copy Markdown
Contributor Author

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@sgugger

sgugger commented Apr 24, 2023

Copy link
Copy Markdown
Collaborator

There are still a couple of comments left to address @gabrielwithappy

@gabrielwithappy

Copy link
Copy Markdown
Contributor Author

@sgugger oh, I just found! I will chech and change to draft before ready-to-review
:-)

@gabrielwithappy
gabrielwithappy marked this pull request as draft April 24, 2023 14:36
Co-Authored-By: Gabriel Yang <gabrielwithhappy@gmail.com>
Co-Authored-By: Nayeon Han <nayeon2.han@gmail.com>
Co-Authored-By: Hyeonseo Yun <0525_hhgus@naver.com>
Co-Authored-By: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-Authored-By: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-Authored-By: Wonhyeong Seo <wonhseo@kakao.com>
@gabrielwithappy
gabrielwithappy marked this pull request as ready for review April 24, 2023 16:44
@gabrielwithappy

gabrielwithappy commented Apr 24, 2023 •

Copy link
Copy Markdown
Contributor Author

@sgugger, @ArthurZucker, @eunseojo
May you please review this PR?
I checked anchors of titles in the doc and fixed all reviews
BRs.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger
sgugger merged commit 7701716 into huggingface:main Apr 24, 2023
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
docs: ko: translates create_a_model.mdx

Co-authored-by: Nayeon Han <nayeon2.han@gmail.com>
Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
docs: ko: translates create_a_model.mdx

Co-authored-by: Nayeon Han <nayeon2.han@gmail.com>
Co-authored-by: Hyeonseo Yun <0525_hhgus@naver.com>
Co-authored-by: Sohyun Sim <96299403+sim-so@users.noreply.github.com>
Co-authored-by: Jungnerd <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Wonhyeong Seo <wonhseo@kakao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants