Repository navigation
Turns out we introduced a regression because bad code. - #1060
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
McPatate
approved these changes
Sep 16, 2022
mishig25
approved these changes
Sep 16, 2022
mishig25
left a comment
mishig25
left a comment
Contributor
There was a problem hiding this comment.
lgtm! curious how this issue was discovered?
Contributor
Author
|
https://huggingface.slack.com/archives/C02CH2YP4EQ/p1663273001253299 Here is the PR I use to run the full test suite: huggingface/transformers#16712 Basically this was caught by a slow pipeline test where the output didn't match the previous version because we rarely test We're running the full test suite before release now on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.