Repository navigation
fix: drop transformers 5.3.0 override - #984
Merged
Merged
Conversation
nixpkgs now ships transformers 5.17.0, which already depends on typer. the 5.3.0 override pins tokenizers<=0.23.0, but nixpkgs has 0.23.2, so any kernel with transformers in its check inputs (mamba-ssm ci-test) failed the runtime deps check and the import check
danieldk
approved these changes
Nov 10, 2026
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr drops the
transformers5.3.0 override fromnix-builder/overlay.nixso the builder uses the nixpkgs version (5.17.0)the override was added in #400 when nixpkgs had a broken 4.57.3. nixpkgs caught up in #425 and since then the override only downgraded transformers. after the nixpkgs bump in #831 it conflicts with tokenizers 0.23.2, since 5.3.0 requires
tokenizers<=0.23.0. this breaks the mamba-ssmci-testhttps://github.com/huggingface/kernels-community/actions/runs/42704254952/job/129457078351pythonRelaxDepsis not enough here since transformers checks the same pin again on import. nixpkgs 5.17.0 allowstokenizers<0.24.0and already depends ontyperbuilt the mamba-ssm
ci-testpython env on x86_64-linux with this branch askernel-builder, transformers 5.17.0 and the env both build