Skip to content

[Liger Kernels] Adding TiledMLP kernels - #918

Merged
danieldk merged 4 commits into
huggingface:mainfrom
ariG23498:liger-tiled-mlp
Jun 4, 2026
Merged

danieldk merged 4 commits into
huggingface:mainfrom
ariG23498:liger-tiled-mlp

Conversation

@ariG23498

Copy link
Copy Markdown
Contributor

@ariG23498
ariG23498 requested review from danieldk and drbh as code owners June 3, 2026 09:58
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Hi @ariG23498, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/huggingface/kernels-community/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this Jun 3, 2026
@sayakpaul sayakpaul reopened this Jun 3, 2026
@sayakpaul

Copy link
Copy Markdown
Member

/kernel-bot build liger-kernels

@github-actions

github-actions Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build liger-kernels
Mode: build only
Target branch: pr-918
PR head SHA: c05653fd7f6ccbf7a2954c1f166be54906c896fa
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@danieldk

danieldk commented Jun 3, 2026

Copy link
Copy Markdown
Member

/kernel-bot build liger-kernels

@github-actions

github-actions Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build liger-kernels
Mode: build only
Target branch: pr-918
PR head SHA: cedae02fe1244f04891c99971b423bdd6653dc48
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

automatically calculated as ``ceil(seqlen / hidden_size)``.
"""

def __init__(self, config, num_shards: Optional[int] = None):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything in the layers module should be a proper kernel layer. See:

#906
https://huggingface.co/docs/kernels/kernel-requirements#layers

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it look better now?

@danieldk

danieldk commented Jun 4, 2026

Copy link
Copy Markdown
Member

/kernel-bot build liger-kernels

@github-actions

github-actions Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build liger-kernels
Mode: build only
Target branch: pr-918
PR head SHA: 3feb431b7020c86c15e944e87119a9dfd941d9dc
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@danieldk

danieldk commented Jun 4, 2026

Copy link
Copy Markdown
Member

/kernel-bot merge-and-update liger-kernels

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

Invalid command. Use /kernel-bot <build|build-and-stage|merge-and-upload|release> <kernel1> [kernel2 ...] [--branch <target_branch>].

@danieldk
danieldk merged commit ab435e2 into huggingface:main Jun 4, 2026
4 of 5 checks passed
@danieldk

danieldk commented Jun 4, 2026

Copy link
Copy Markdown
Member

/kernel-bot merge-and-upload liger-kernels

@github-actions

github-actions Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot merge-and-upload liger-kernels
Mode: merge, build and upload
Target branch: ``
PR head SHA: 3feb431b7020c86c15e944e87119a9dfd941d9dc
Workflows: `build.yaml, build-mac.yaml, build-windows.yaml`

Merge result: PR is already merged. Continuing with build/upload.

Dispatched (1):

sayakpaul pushed a commit that referenced this pull request Jun 5, 2026
* chore: adding liger tiled mlp kernels

* liger-kernels: test with Triton ROCm binary wheels

* chore: align layer to pure

---------

Co-authored-by: Daniël de Kok <me@danieldk.eu>
sayakpaul added a commit that referenced this pull request Jun 5, 2026
sayakpaul added a commit that referenced this pull request Jun 5, 2026
* feat: allow kernel-bot to run security analysis.

* include security in the build.

* megablocks for rocm (#916)

* feat: update merge-and-upload permissions (#930)

* [Liger Kernels] Adding TiledMLP kernels (#918)

* chore: adding liger tiled mlp kernels

* liger-kernels: test with Triton ROCm binary wheels

* chore: align layer to pure

---------

Co-authored-by: Daniël de Kok <me@danieldk.eu>

* finegrained-fp8: MXFP4 recipes (#923)

* add fp4 matmul kernels for deepseek v4 flash

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>

* add missing source code..

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>

* update

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>

* update to w4a8

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>

* update

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>

* perf optimization add add benchmark_perf.py script

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>

* structure

* standarize all kernels and testing around the same api

* better testing framework

* fix batched with sentinels

* tests with sentinels as well

* test static and support ue8m0

* specify v2 as the version

* cleanup

* naming convention

* update readme

* remove bench

* format

* update readme

* trigger

* skip tests on < sm89

* drop sm89 testing, too error prone

* Use triton-rocm-fixes branch to pass build

* Update build.toml

* Fix Torch ops

* Remove custom path insertion

This breaks tests in kernel-builder devshells

---------

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Co-authored-by: Wang, Yi <yi.a.wang@intel.com>
Co-authored-by: Daniël de Kok <me@danieldk.eu>

* address review feedback

* Revert "megablocks for rocm (#916)"

This reverts commit e06068f.

* Revert "feat: update merge-and-upload permissions (#930)"

This reverts commit a913728.

* Revert "[Liger Kernels] Adding TiledMLP kernels (#918)"

This reverts commit 3d9bb2f.

* Revert "finegrained-fp8: MXFP4 recipes (#923)"

This reverts commit 9f9d5e1.

* security-and-build

---------

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Co-authored-by: BADAOUI Abdennacer <106801897+Abdennacer-Badaoui@users.noreply.github.com>
Co-authored-by: drbh <david.richard.holtz@gmail.com>
Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com>
Co-authored-by: Daniël de Kok <me@danieldk.eu>
Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com>
Co-authored-by: Wang, Yi <yi.a.wang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants