Repository navigation
[Liger Kernels] Adding TiledMLP kernels - #918
Conversation
|
Hi @ariG23498, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/huggingface/kernels-community/blob/main/CONTRIBUTING.md for more details. |
|
/kernel-bot build liger-kernels |
|
Build request processed. Command: Dispatched (1):
|
|
/kernel-bot build liger-kernels |
|
Build request processed. Command: Dispatched (1):
|
| automatically calculated as ``ceil(seqlen / hidden_size)``. | ||
| """ | ||
|
|
||
| def __init__(self, config, num_shards: Optional[int] = None): |
There was a problem hiding this comment.
Anything in the layers module should be a proper kernel layer. See:
#906
https://huggingface.co/docs/kernels/kernel-requirements#layers
There was a problem hiding this comment.
Does it look better now?
|
/kernel-bot build liger-kernels |
|
Build request processed. Command: Dispatched (1):
|
|
/kernel-bot merge-and-update liger-kernels |
|
Invalid command. Use |
|
/kernel-bot merge-and-upload liger-kernels |
|
Build request processed. Command: Merge result: PR is already merged. Continuing with build/upload. Dispatched (1):
|
* chore: adding liger tiled mlp kernels * liger-kernels: test with Triton ROCm binary wheels * chore: align layer to pure --------- Co-authored-by: Daniël de Kok <me@danieldk.eu>
* feat: allow kernel-bot to run security analysis. * include security in the build. * megablocks for rocm (#916) * feat: update merge-and-upload permissions (#930) * [Liger Kernels] Adding TiledMLP kernels (#918) * chore: adding liger tiled mlp kernels * liger-kernels: test with Triton ROCm binary wheels * chore: align layer to pure --------- Co-authored-by: Daniël de Kok <me@danieldk.eu> * finegrained-fp8: MXFP4 recipes (#923) * add fp4 matmul kernels for deepseek v4 flash Signed-off-by: Wang, Yi <yi.a.wang@intel.com> * add missing source code.. Signed-off-by: Wang, Yi <yi.a.wang@intel.com> * update Signed-off-by: Wang, Yi <yi.a.wang@intel.com> * update to w4a8 Signed-off-by: Wang, Yi <yi.a.wang@intel.com> * update Signed-off-by: Wang, Yi <yi.a.wang@intel.com> * perf optimization add add benchmark_perf.py script Signed-off-by: Wang, Yi <yi.a.wang@intel.com> * structure * standarize all kernels and testing around the same api * better testing framework * fix batched with sentinels * tests with sentinels as well * test static and support ue8m0 * specify v2 as the version * cleanup * naming convention * update readme * remove bench * format * update readme * trigger * skip tests on < sm89 * drop sm89 testing, too error prone * Use triton-rocm-fixes branch to pass build * Update build.toml * Fix Torch ops * Remove custom path insertion This breaks tests in kernel-builder devshells --------- Signed-off-by: Wang, Yi <yi.a.wang@intel.com> Co-authored-by: Wang, Yi <yi.a.wang@intel.com> Co-authored-by: Daniël de Kok <me@danieldk.eu> * address review feedback * Revert "megablocks for rocm (#916)" This reverts commit e06068f. * Revert "feat: update merge-and-upload permissions (#930)" This reverts commit a913728. * Revert "[Liger Kernels] Adding TiledMLP kernels (#918)" This reverts commit 3d9bb2f. * Revert "finegrained-fp8: MXFP4 recipes (#923)" This reverts commit 9f9d5e1. * security-and-build --------- Signed-off-by: Wang, Yi <yi.a.wang@intel.com> Co-authored-by: BADAOUI Abdennacer <106801897+Abdennacer-Badaoui@users.noreply.github.com> Co-authored-by: drbh <david.richard.holtz@gmail.com> Co-authored-by: Aritra Roy Gosthipaty <aritra.born2fly@gmail.com> Co-authored-by: Daniël de Kok <me@danieldk.eu> Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com> Co-authored-by: Wang, Yi <yi.a.wang@intel.com>
In this PR I am upstreaming the Liger Kernels repo to add the Tiled MLP kernels.
Refereces:
Let me know if I have to trigger a build for them. 🤗