Repository navigation
Conversation
write_basic_config (and so `accelerate config default`) had no branch for MPS, so on Apple Silicon it fell through to the CPU-only branch and wrote use_cpu: true. Scripts launched with that config then ran on the CPU even though the MPS device was available. Add an MPS branch that writes a single-process, non-CPU config. Signed-off-by: Udaya Tejas <udayatejas2004@gmail.com>
|
I tested this on an Apple M5 Pro (macOS 26.6.2, Python 3.14, torch 2.15.0), PR head
(Testing was done with help from Claude Code; I checked the results.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
write_basic_config(used byaccelerate config default) has no branch for MPS, so on Apple Silicon it falls through to the CPU-only branch and writesuse_cpu: true. Any script launched with that config then runs on the CPU even though MPS is available. Launching without a config, or using the interactiveaccelerate config, correctly uses MPS.Repro on an M-series Mac:
This adds an MPS branch that writes a single-process, non-CPU config, plus
test_write_basic_config_mpsintests/test_cli.py, which mocks MPS availability so it also runs on CPU CI. The test fails onmain(use_cpuisTrue) and passes with the fix;tests/test_cli.pypasses (44 passed, 1 skipped).Before submitting
Who can review?
@SunMarc