Repository navigation
Honor scheduler adjustment during gradient accumulation - #4262
Closed
vineethsaivs wants to merge 1 commit into
Closed
vineethsaivs wants to merge 1 commit into
vineethsaivs wants to merge 1 commit into
Conversation
Match the declared default, guard schedulers without a step counter, and use OneCycle last_epoch to limit actual scheduler updates.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GradientAccumulationPlugin(adjust_scheduler=True) is silently treated as False because default-valued options are omitted from the stored kwargs.
Cause: GradientState uses a False fallback although the plugin declares True.
Fix: Match the declared default, guard schedulers without a step counter, and use OneCycle last_epoch to limit actual scheduler updates. Restoring the default otherwise exposes plateau schedulers without _step_count and stops OneCycle early.
Test:
PYTHONPATH=src ACCELERATE_USE_CPU=true python -m pytest tests/test_scheduler.py -k SchedulerAdjustmentTester -q. Both new test methods and four subcases pass. Eight existing single-process scheduler checks pass. Restoring the default alone reproduced a plateau AttributeError and premature OneCycle stopping, both covered by the fix. Changed-file pre-commit passes. CPU only; nine host-conditional tests skip on this Mac.