Skip to content

fix: bootstrap saves executable test_cmds; normalize strips -q - #23

Merged
adithya-s-k merged 1 commit into
huggingface:mainfrom
sergiopaniego:fix/bootstrap-test-cmds-verbose
May 19, 2026
Merged

adithya-s-k merged 1 commit into
huggingface:mainfrom
sergiopaniego:fix/bootstrap-test-cmds-verbose

Conversation

@sergiopaniego

Copy link
Copy Markdown
Member

Bootstrap prompt previously instructed the agent to save --collect-only as test_cmds. Downstream pipelines (mutation_bugs, pr_runtime) need actual test execution with per-test pass/fail output to find baseline passing tests and F2P signal — collect-only produces neither.

Two related fixes in normalize_test_cmds_for_runtime:

  • Already stripped --collect-only; now also strips -q/--quiet, which cancels -v in pytest 9's verbosity counter, causing the log parser to see 0 passing tests even when tests ran.

Existing cached bootstraps are safe: normalize handles both flags so no forced rebuild is required.

@adithya-s-k
adithya-s-k merged commit fa2a7dc into huggingface:main May 19, 2026
5 checks passed
@sergiopaniego
sergiopaniego deleted the fix/bootstrap-test-cmds-verbose branch May 19, 2026 07:54
@adithya-s-k

Copy link
Copy Markdown
Collaborator

thanks @sergiopaniego for fixing the bootstrap test commands and quiet-flag handling, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants