Update remote contiguous length even not fullycontig - #858
Draft
lejeunerenard wants to merge 7 commits into
Draft
Conversation
Goes against the previous behavior where it only was forced when the peer became fully contiguous, but this meant that remotes didn't know if the peer was contiguous then.
Unsoloed so will run the full suite now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #857's test. This solution will break the documented behavior in favor of the more intuitive idea that
remote-contiguous-lengthevent will fire for all updates to the remote contig length, not just when it's fully contiguous.Other methods will be explored so keeping draft for now.
This PR is AI assisted.