Support premature termination of listing - #928
Merged
Merged
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the notion of a
RemoteResourceSelectorwhich is a more powerful alternative of the existingRemoteResourceFilterallowing to terminate a listing prematurely.An improvement to Apache NiFi aims to support listing a configured maximum of remote file resources.
As of now, this can be achieved by providing a
RemoteResourceFilterthat returnsfalsefor allRemoteResourceInfoafter the configured threshold has been reached. However,sshjwill list all files under the hood nonetheless, which has huge affect on listing performance, especially for directories a with large amount of files.The PR also resolved a
TODOto remove the GOTO that resided in the code touched.Please let me know if this is a good trajectory for addressing the underlying problem stated or whether it should be addressed differently or any other changes should be incorporated.