full support for encrypted PuTTY v3 files - #730
Conversation
…PuTTYArgon2 class for an easy Argon2 integration
|
@hierynomus Would be acceptable to add the unit test shown in my first comment? If we would include this dependency the unit tests would only be executable on these platforms by default. |
|
@jpstotz SSHJ currently includes a dependency on Bouncy Castle, which includes an Argon2 implementation, what do you think about providing an implementation based on the Bouncy Castle class Argon2BytesGenerator? @hierynomus has mentioned attempting to avoid unnecessary dependencies on Bouncy Castle, but perhaps this is worth including? |
|
@exceptionfactory Thanks, I did not know that BouncyCastle already contains an Argon2 implementation. That really simplifies everything. |
|
I think this PR is finally complete and ready to merge. The unit tests now cover all the variants and they verify that the keys has been loaded correctly. |
Based on my patch yesterday I have implemented full support for encrypted PuTTY v3 keys.
Edit 2: Finally thanks to BouncCastle Argon2 implementation no external dependencies and interface is needed anymore. Unit test is in place and works