Repository navigation
fix(share): reject malformed workspace capability responses - #7472
Merged
terencecho merged 1 commit intoNov 10, 2026
Merged
terencecho merged 1 commit into
terencecho merged 1 commit into
Conversation
terencecho
merged commit Nov 10, 2026
00d2562
into
codex/share-reinvite-revision
54 of 55 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject successful review-spaces responses that do not contain a workspace list before returning capability flags. A malformed response must not enable sharing. Empty lists remain valid, and flags still require explicit boolean true.
Five focused regressions cover missing, null and non-list payloads plus valid empty lists. Four fail without the guard. All 48 shared-kernel tests, declaration build, lint/format and normal commit hooks pass. No live backend or visual behavior was exercised.
Stacked on #7470; this follow-up does not change that queued PR.