Skip to content

docs(cli): correct Claude Code marker comments in agent detection - #7426

Merged
jrusso1020 merged 1 commit into
mainfrom
agent-runtimes-comment-nits
Nov 9, 2026
Merged

jrusso1020 merged 1 commit into
mainfrom
agent-runtimes-comment-nits

Conversation

@jrusso1020

Copy link
Copy Markdown
Collaborator

Problem

Two comments in agent_runtime.ts were wrong after #7425 (review nits on that PR):

  • The Claude Code rule called CLAUDE_CODE_ENTRYPOINT an "older versions" marker. Current Claude Code sets it on itself at startup, and it is the only Claude marker that stdio MCP servers inherit, so the label invited someone to delete a marker we still need.
  • The Agent SDK rule said Claude Code's shell tool sets CLAUDECODE. The Claude rule now keys on CLAUDE_CODE_CHILD_SESSION.

Changes

Comment wording only in packages/cli/src/telemetry/agent_runtime.ts. No code or behavior change.

Verification

  • oxfmt --check, comment-ratchet and check-comment-citations pass locally.

— Rames

🤖 Generated with Claude Code

CLAUDE_CODE_ENTRYPOINT is set by current Claude Code versions too, and it
is the only Claude marker MCP servers inherit, so it is not an
"older versions" fallback. The Agent SDK comment still said Claude Code's
shell tool sets CLAUDECODE; the rule keys on CLAUDE_CODE_CHILD_SESSION.

Follow-up to review nits on #7425. Comments only.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Edit accuracy: accurate 267 (base branch 267), smooth 90 of those

The gate passes.
Smoothness is reported in the artifact, not gated. A case fails only if it fails 2 of 3 runs.

Quarantined, measured but not gated (8)

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT (needs human) · 0 blocker · 0 important · 0 nits · head 9a0c86d

Both comments now match the code. claude_code keys on CLAUDE_CODE_CHILD_SESSION || CLAUDE_CODE_ENTRYPOINT (L99–104), so dropping "older versions" keeps someone from deleting a marker the rule still needs. The SDK comment's "caught above" now names the marker that rule actually checks. I'd approve on the merits. I'm holding approval only because the required check Tests on windows-latest is red. The failing test is @hyperframes/engine browserManager.test.ts > BeginFrame capability probe > reports an empty screenshot as unsupported (cli: 4411 passed). A comments-only change can't cause that, and the same workflow also failed on a recent main push, so it looks like a flake. Re-running the failed job should clear it.

— Genesis

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE · 0 blocker · 0 important · 0 nits · 9a0c86d

Windows re-run (attempt 2) is green on the same head, so the earlier hold is cleared.

— Genesis

@jrusso1020
jrusso1020 added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit e351253 Nov 9, 2026
91 of 93 checks passed
@jrusso1020
jrusso1020 deleted the agent-runtimes-comment-nits branch November 9, 2026 04:46
@miguel-heygen miguel-heygen mentioned this pull request Nov 9, 2026
3 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant