Repository navigation
fix(core): a rejected buildReady hold fails the render with its reason - #7150
Closed
xunguangzlj-cloud wants to merge 1 commit into
Closed
xunguangzlj-cloud wants to merge 1 commit into
xunguangzlj-cloud wants to merge 1 commit into
Conversation
3 tasks done
Author
|
Closing — #5746's channel now does what this PR did: a rejected build hold records its reason () and surfaces it through the same comparison my change targeted, so capture fails with the reason instead of silently rendering empty frames. Happy to see the scenario covered by the maintainer's own implementation; nothing left to merge here. |
Author
|
Corrections to my own note above (the shell ate the backticks): the channel is |
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
…view to heygen-com#7265 Adopt heygen-com#7284 (Studio Storyboard tab and `doc: "storyboard"` Desktop handoff, adapted to the fork's desktopApp without heygen-com#6897) and heygen-com#7324 (drawElement gate: webgl_unavailable / beginframe_no_self_verify). PR axis heygen-com#7260-heygen-com#7265 carries earlier verdicts; re-pin heygen-com#6695 and heygen-com#6816, resolve heygen-com#7150 as superseded by heygen-com#5746. Watermarks: commit 18fc75d, PR heygen-com#7265, issue heygen-com#7223, monitored 99. Co-authored-by: WaterrrForever <miao.yang@heygen.com> Co-authored-by: Vance Ingalls <vance@heygen.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5603
What
A rejected
window.__hf.buildReadyhold is now a named build failure: the runtime records it on the startup-error channel (recordStartupError→window.__hfStartupError), so capture'swaitForRuntimeReadythrows with the composition's own rejection reason and the render fails non-zero — instead of treating the hold as released, rendering every frame of a scene that never built, and exiting 0.Why
From #5603: the runtime waited on
buildReadypromises throughcreateSettledTracker, whose rejection path marked the wait settled andswallow()ed the reason. Check reported 0 errors and render exited 0 with empty frames; the rejection reason was invisible (debug-only via__hfDebug). A pipeline that trusts the exit code ships a broken film.How
One branch: the
isBuildReadinessSettledtracker's rejection callback now callsrecordStartupError(err)(the existing named channel, already used by the start-up failure path at init.ts and consumed bycaptureCompositionFrame.ts'swaitForRuntimeReady, which throws when__hfStartupErroris set) before the existingswallow(kept, so Studio's__hf.onSwallowedcollectors still see the event). Resolve semantics are untouched: holds that resolve still release the wait exactly as before, and the stale-registry teardown behavior is unchanged.Test
fails without the fix:
pnpm vitest run src/runtime/init.test.ts -t "buildReady"— "names a rejected buildReady hold on the startup-error channel instead of releasing silently (#5603)" assertswindow.__hfStartupErrornames the rejection; onmainit stays undefined (the release path) and the test fails.pnpm vitest run src/runtime/init.test.ts -t "buildReady": 4 passed (was 3 passed / 1 failed onmain); the sibling resolve/teardown buildReady tests are untouched.pnpm vitest run src/runtime/init.test.ts: whole family passes (268 tests).tsc --noEmit -p tsconfig.runtime.jsonclean;oxlinton both files clean.