Repository navigation
chore(parsers): raise the package size budget to the measured size plus headroom - #6457
Merged
Merged
Conversation
![heygengenesis[bot]](https://avatars.githubusercontent.com/in/2913576?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 195af01c
The new budgets match the failed queue Build (run 40370172011, parsers at 194029 packed and 843156 unpacked) × 1.05, rounded up: 203731 and 885314. Only the parsers entry changes. CI on this head is green, including Build's verify:packed-manifests; CodeQL and Windows render verification are still running.
miguel-heygen
enabled auto-merge
October 26, 2026 18:09
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Oct 26, 2026
Brings in 10 upstream commits (ad4d3fa..15367a9): heygen-com#6425, heygen-com#6427, heygen-com#6429, heygen-com#6431, heygen-com#6436, heygen-com#6432, heygen-com#6453, heygen-com#6457, heygen-com#6450, heygen-com#6451. One conflict, packages/core/src/compiler/compositionScoping.ts (heygen-com#6436). This fork passes authored composition code to Function() as a JSON string literal, so upstream's markers around the raw source would sit outside the text its page-side scan reads and the fix would silently not apply: the wrapper's own __timelines use would make every composition look able to register a timeline. The markers go inside the literal instead, begin marker on the first source line so error line numbers do not shift. The pageBuild goldens change only by those two marker comments. A new engine test runs upstream's scan on this fork's real wrapper output and fails without the markers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 of 4 tasks
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the
@hyperframes/parserssize budget to its measured size plus 5% headroom: packed 191000 → 203731, unpacked 831243 → 885314.Why
#5255 (media source writes resolved in their lexical scopes) adds real code to
packages/parsers/src/mediaSrcMutation.ts(+190/−27). With it,verify:packed-manifestsmeasures parsers at 194029 packed and 843156 unpacked, over the budget by more than the 1% allowance, so its merge-queue group failed Build. Main on its own already measures about 0.5% over the unpacked budget, so the next parsers change would hit the same wall. Same approach as #6370: measured size plus headroom.Test plan
pnpm packofpackages/parserson main and with fix(parsers): resolve media source writes in their lexical scopes #5255 applied: unpacked 835158 → 843156 (+7998, matching the Build log exactly).Why under 100 lines
A lone urgent budget fix: it is the change that lets the merge queue take #5255 again, and there is no open PR of ours it belongs in.