Skip to content

test(lint): cover template-root composition variable declarations #6150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrusso1020 merged 1 commit into from
Nov 8, 2026
Merged

test(lint): cover template-root composition variable declarations #6150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/lint/src/rules/composition.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,15 @@ describe("composition rules", () => {
expect(finding).toBeDefined();
});

it("checks a declaration on a template-fragment composition root", async () => {
const html = `<template><div id="main" data-composition-id="main" data-no-timeline data-width="1920" data-height="1080" data-duration="10" data-composition-variables='broken'></div></template>`;
const result = await lintHyperframeHtml(html, { isSubComposition: true });
const finding = result.findings.find(
(f) => f.code === "invalid_composition_variables_declaration",
);
expect(finding).toBeDefined();
});

it("warns when data-composition-variables is unparseable JSON", async () => {
const html = `<html data-composition-variables='[{not json'><body><div data-composition-id="x"></div></body></html>`;
const result = await lintHyperframeHtml(html);
Expand Down
Loading