Repository navigation
test(studio): the A-roll backdrop check fails if Studio stops stamping the backdrop - #5476
Merged
Merged
Conversation
somanshreddy
approved these changes
Oct 11, 2026
somanshreddy
left a comment
Contributor
There was a problem hiding this comment.
Review at c4b2e69c: no blockers, approving.
- The assertion matches what the runtime writes.
init.tsstamps withsetAttribute(RUNTIME_STAMPED_ATTR, "1")(lines 2065 and 2090), andRUNTIME_STAMPED_ATTRis"data-hf-autostamped". SoplateStamped !== "1"checks the exact value, and an unstamped plate (null) fails with a clear message. - It runs in CI.
aroll-backdrop.mjsruns in thestudio-timeline-viewportjob (ci.yml, line 1035). That job ("Studio: timeline viewport gate") passed at this head. Its log shows"plateStamped": "1"on every reading and"failures": [], so the new assertion actually ran and held, not just a skip. - The diff is tiny: one test file, +7/-1. The failure feeds the existing
failureslist, which exits 1. All required checks are green.
— Somu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The Studio A-roll backdrop check added in #5475 now also fails if Studio stops stamping the backdrop with
data-hf-autostamped. Before, it only recorded the stamp, so if Studio ever stopped stamping it, the fixture would quietly stop testing the shape it exists for (a preview-stamped element the project's own script hides).No visible change
Test-only: one assertion in
packages/studio/tests/e2e/aroll-backdrop.mjs.Checked
studio-timeline-viewportCI job runs it: exit 0 three times in a row, every readingplateStamped: "1".packages/core/src/runtime/init.tsswitched off and the runtime rebuilt: exit 1 withpaused-start: #plate is not stamped (data-hf-autostamped=null).