Repository navigation
fix(cli): include external video posters in project archives - #5309
miguel-heygen merged 4 commits into
Conversation
|
Thanks for this, @user-github-me. This PR now has merge conflicts with |
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
miguel-heygen
left a comment
There was a problem hiding this comment.
Thanks for rebasing this. The fix is the right size: the publish path now asks the shared rewriteHtmlAttributes helper to look at poster as well as src and href, which matches what the cloud upload path in cloud/offload.ts already does. Remote, inline and in-project posters go through the same resolver and stay untouched, and your second test pins that. The tests go through createPublishArchive, which is what publishing uses, they cover a nested composition file, and they check the source HTML on disk is not modified. CI is green and the branch merges cleanly with main.
An optional follow-up, not for this PR: the same external-asset scan in publishing does not look at srcset, while the cloud path does (rewriteSrcsets), so an image srcset pointing outside the project would still be left out of the archive.
Verdict: APPROVE
Reasoning: One-line fix through the shared helper, matching the cloud path, with tests on the real archive entry point, green CI and no conflicts.
A video poster stored outside the project directory is omitted from a published archive because external-asset localization only inspects
srcandhref. Includeposterin that scan so the image is copied into_ext/and its reference is rewritten relative to the archived HTML file.The current-main integration uses the shared attribute/style resolver and preserves on-disk asset staging for cloud archives. The sharing guide documents external-poster inclusion. Root and nested HTML poster references are covered, including archive contents, relative paths and unchanged source HTML; internal, remote and inline poster references remain covered as well.
Validation: 67 publishing, archive and proxy-baking tests pass. The two tests requiring a live authenticated publishing server remain skipped. CLI build/typecheck, formatting, lint, test reachability, both comment checks, Mint validation/link checks and normal commit hooks pass against the previously built current-main workspace.