Skip to content

fix(cli): include external video posters in project archives - #5309

Merged
miguel-heygen merged 4 commits into
heygen-com:mainfrom
user-github-me:fix/publish-external-video-posters
Oct 25, 2026
Merged

miguel-heygen merged 4 commits into
heygen-com:mainfrom
user-github-me:fix/publish-external-video-posters

Conversation

@user-github-me

@user-github-me user-github-me commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

A video poster stored outside the project directory is omitted from a published archive because external-asset localization only inspects src and href. Include poster in that scan so the image is copied into _ext/ and its reference is rewritten relative to the archived HTML file.

The current-main integration uses the shared attribute/style resolver and preserves on-disk asset staging for cloud archives. The sharing guide documents external-poster inclusion. Root and nested HTML poster references are covered, including archive contents, relative paths and unchanged source HTML; internal, remote and inline poster references remain covered as well.

Validation: 67 publishing, archive and proxy-baking tests pass. The two tests requiring a live authenticated publishing server remain skipped. CLI build/typecheck, formatting, lint, test reachability, both comment checks, Mint validation/link checks and normal commit hooks pass against the previously built current-main workspace.

@jrusso1020

Copy link
Copy Markdown
Collaborator

Thanks for this, @user-github-me. This PR now has merge conflicts with main. Could you rebase it onto the latest main? Once it's conflict-free we'll review it and get it into the merge queue.

@mintlify

mintlify Bot commented Oct 24, 2026

Copy link
Copy Markdown

Preview approval required

This pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit a14c5d9.

Approve preview

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing this. The fix is the right size: the publish path now asks the shared rewriteHtmlAttributes helper to look at poster as well as src and href, which matches what the cloud upload path in cloud/offload.ts already does. Remote, inline and in-project posters go through the same resolver and stay untouched, and your second test pins that. The tests go through createPublishArchive, which is what publishing uses, they cover a nested composition file, and they check the source HTML on disk is not modified. CI is green and the branch merges cleanly with main.

An optional follow-up, not for this PR: the same external-asset scan in publishing does not look at srcset, while the cloud path does (rewriteSrcsets), so an image srcset pointing outside the project would still be left out of the archive.

Verdict: APPROVE
Reasoning: One-line fix through the shared helper, matching the cloud path, with tests on the real archive entry point, green CI and no conflicts.

@miguel-heygen
miguel-heygen added this pull request to the merge queue Oct 25, 2026
Merged via the queue into heygen-com:main with commit e5e2d6f Oct 25, 2026
113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants