Skip to content

fix: preserve invalidation across chained retargets - #165

Merged
HemSoft merged 1 commit into
mainfrom
fix/issue-139-protect-retarget-invalidation
Oct 8, 2026
Merged

HemSoft merged 1 commit into
mainfrom
fix/issue-139-protect-retarget-invalidation

Conversation

@HemSoft

@HemSoft HemSoft commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

A same-head retarget from main to release, followed quickly by release to other, could cancel the first invalidation before the second event returned as unsupported. The old green gate could survive that sequence. Partition the pull-context concurrency group by default-branch review eligibility so unsupported retargets cannot cancel supported invalidation. Preserve the existing admission and pause contracts.

Publish this correction as 2.1.0-rc.29. It inherits rollout issue #139; that issue remains open for fleet delivery. The original finding is mcp-server-demo #5.

Acceptance criteria

  • Chained nondefault retargets cannot cancel a pending or running default-departure invalidation. The regression evaluates the actual YAML concurrency expression, including a chain returning to the same nondefault target.
  • Default-target/default-departure events retain shared serialization; other pull requests remain independent.
  • Nondefault-to-nondefault events remain outside gate publication; fork admission remains unchanged.
  • Installed and distributed workflows are byte-identical; release metadata and install guidance identify rc29.

Definition of done

  • Minimal correction and executable regression on both production workflow copies.
  • Actual new commit author and committer verified as Franz Hemmer, 8227352+HemSoft@users.noreply.github.com, before push.
  • Current-head connected Codex review and required CI. The registered request 6068512922 and clean artifact 6068606965 bind head 2401917622af126307f766cc02e0509a7cefc5d8, base 104648b0a9f2709c15d2cfb6c9b7d9dc49e171b3 and the successful Actions gate execution. All applicable PR checks pass; no finding or unresolved thread remains. The original strict organization rule has no bypass actors and no formal approval requirement.
  • Signed publication and fresh installed consumer qualification. Fleet defaults remain held until those checks pass.

Validation

  • node deployment/tests/test-final-review-history.cjs <workflow> probe-retarget: original signed rc28 fails the new chained-retarget assertion; corrected workflow passes.
  • node deployment/tests/test-final-review-history.cjs <workflow>: both production copies pass.
  • python3 -B -m unittest discover -s deployment/tests -p test_org_rollout.py -v: 273 tests pass.
  • The unchanged observer fixture runner passes all 13 original scenarios against the source candidate. These are synthetic source tests, not installed or live provider evidence.
  • test-sfl-pr-review.ps1, test-sfl-review-platform.ps1, test-release-metadata.ps1, test-release-installer.ps1: pass with the declared Go toolchain.
  • Pinned actionlint 1.7.12 reports only its existing unsupported queue: max diagnostic. The new expression adds no diagnostics; the queue setting is unchanged.
  • git diff --check: pass.

Risks and deferred work

GitHub concurrency documentation describes cancellation within a concurrency group. The correction separates unsupported events before job execution; it does not rely on their early return preventing cancellation. Signed release verification, installed public/private qualification, and fleet delivery belong to #139 and remain pending.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T20:38:05.041799Z 2401917 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@HemSoft

HemSoft commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 2401917622

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft
HemSoft merged commit f07ab8c into main Oct 8, 2026
16 checks passed
@HemSoft
HemSoft deleted the fix/issue-139-protect-retarget-invalidation branch October 8, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant