Repository navigation
fix: preserve invalidation across chained retargets - #165
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
16 tasks done
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A same-head retarget from
maintorelease, followed quickly byreleasetoother, could cancel the first invalidation before the second event returned as unsupported. The old green gate could survive that sequence. Partition the pull-context concurrency group by default-branch review eligibility so unsupported retargets cannot cancel supported invalidation. Preserve the existing admission and pause contracts.Publish this correction as
2.1.0-rc.29. It inherits rollout issue #139; that issue remains open for fleet delivery. The original finding is mcp-server-demo #5.Acceptance criteria
Definition of done
8227352+HemSoft@users.noreply.github.com, before push.2401917622af126307f766cc02e0509a7cefc5d8, base104648b0a9f2709c15d2cfb6c9b7d9dc49e171b3and the successful Actions gate execution. All applicable PR checks pass; no finding or unresolved thread remains. The original strict organization rule has no bypass actors and no formal approval requirement.Validation
node deployment/tests/test-final-review-history.cjs <workflow> probe-retarget: original signed rc28 fails the new chained-retarget assertion; corrected workflow passes.node deployment/tests/test-final-review-history.cjs <workflow>: both production copies pass.python3 -B -m unittest discover -s deployment/tests -p test_org_rollout.py -v: 273 tests pass.test-sfl-pr-review.ps1,test-sfl-review-platform.ps1,test-release-metadata.ps1,test-release-installer.ps1: pass with the declared Go toolchain.queue: maxdiagnostic. The new expression adds no diagnostics; the queue setting is unchanged.git diff --check: pass.Risks and deferred work
GitHub concurrency documentation describes cancellation within a concurrency group. The correction separates unsupported events before job execution; it does not rely on their early return preventing cancellation. Signed release verification, installed public/private qualification, and fleet delivery belong to #139 and remain pending.