Skip to content

fix: verify registry-free review request intent - #164

Merged
HemSoft merged 2 commits into
mainfrom
migration/review-marker-admission
Oct 8, 2026
Merged

HemSoft merged 2 commits into
mainfrom
migration/review-marker-admission

Conversation

@HemSoft

@HemSoft HemSoft commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Description

An authorized ordinary comment quoting an SFL marker can look like a fresh request while its registry is absent and block a valid review. Authenticate an exact, unchanged current request and bind its token to unique trusted head/base context provenance before admitting that run. Retain a verified run/comment/actor identity across later polls until the run ends, so edits, deletion or authorization loss cannot release serialization early.

Registered revocation and genuine fresh-request serialization remain intact. Advance immutable release metadata and onboarding documentation to rc28; the published signed rc27 remains unchanged.

Validation

  • Quoted-marker regression fails against canonical and API-captured installed rc27; the correction passes.
  • Published first head 89d4309 fails separate production controls for arbitrary context and a previously verified request disappearing after mutation. Corrected head 47cb10b passes both.
  • Controls cover quotations/trailing prose, stale head/base, invalid contexts and provenance, edits/deletion, author mismatch, access loss, unrelated run identity and API failure. Genuine fresh requests wait; registered revoked authors still invalidate.
  • Corrected whole production regressions, full Go tests and reviewer/platform contracts pass. Release metadata checks passed, with metadata unchanged in the follow-up.
  • All 273 corrected rollout tests pass, 116.114 seconds. All 13 unchanged frozen observer scenarios pass at corrected head 47cb10b. These are source synthetic checks; signed release and installed/live qualification remain separate.
  • Canonical/staged workflow bytes match; actual author and committer verified before publishing. Clean own worktree after the complete test run.

Both corrected installed/live pilots must qualify before wider rollout.

Refs #139 and finding hemsoft-dev/sfl-migration-pilot-public#14 (comment).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T18:29:06.743247Z 47cb10b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@HemSoft

HemSoft commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 89d4309f84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft

HemSoft commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 47cb10b5e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft
HemSoft merged commit 104648b into main Oct 8, 2026
24 checks passed
@HemSoft
HemSoft deleted the migration/review-marker-admission branch October 8, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant