Skip to content

chore: deploy Set it Free Loop (review tier, v2.0.0) - #384

Merged
HemSoft merged 14 commits into
mainfrom
sfl/tier-review
Aug 2, 2026
Merged

HemSoft merged 14 commits into
mainfrom
sfl/tier-review

Conversation

@HemSoft

@HemSoft HemSoft commented Aug 1, 2026 •

Copy link
Copy Markdown
Collaborator

Set it Free Loop — Deployment

Version: 2.0.0
Tier: review
Source SHA: 380fe0edc7a87cfc7b31233a955b37df0223a3a8
Engine policy: codex-gpt-55-high

Components deployed

  • labels
  • governance
  • sfl-pr-review

What is the Set it Free Loop?

The Set it Free Loop is a continuous
quality improvement operating model for software repositories. See the
CATALOG
for all available workflows.

Before merging

  • Run .\deployment\governance\setup-labels.ps1 -Owner <org> -Repo <repo> if labels are not yet configured
  • For each .md workflow: verify gh aw compile .github/workflows/<name>.md succeeds
  • Trigger a workflow manually to confirm output
  • Review sfl.json manifest in the repo root

Summary by cubic

Deploys Set it Free Loop v2.0.0 to add a label-triggered, full-spectrum PR review using moonshotai/kimi-k3 via OpenRouter. Tightens deterministic validation to pin outputs to the triggering head, require complete validated review output, add a final output gate, and enforce stricter review/check consistency, including the approval check title.

  • New Features

    • Adds sfl-pr-review workflow triggered by sfl-review; runs security/correctness/quality passes, posts up to 20 inline threads, submits one consolidated review, and publishes the SFL Reviewer Approval check.
    • Hardens validation: verifies live PR state, repo/PR targeting, severity prefixes, exact shapes for the consolidated review and check summary, and the check title; pins to head_sha; blocks on head drift with noop; rejects contradictory and incomplete outputs.
    • Supports deleted-line findings in inline review comments by using side: LEFT.
    • Updates sfl.json to register sfl-pr-review on copilot using moonshotai/kimi-k3 with OPENROUTER_API_KEY; adds an SFL upstream badge to README.md; bumps github/gh-aw-actions/setup to v0.84.1.
  • Migration

    • Ensure the sfl-review label and OPENROUTER_API_KEY exist; compile the .md workflow and test by labeling a PR.
    • Verify head guard, inline comments (including deleted lines), consolidated review, approval check (title and summary), overflow handling, the inventory/noop gate, and the stricter validator rejecting incomplete or contradictory outputs.

Written for commit 8352693. Summary will update on new commits.

Review in cubic

Note

Deploy Set it Free Loop PR review workflow (v2.0.0) using kimi-k3 model

  • Adds sfl-pr-review.md and its generated lock file sfl-pr-review.lock.yml, which trigger an automated PR review agent when the sfl-review label is applied.
  • The agent emits inline comments (up to 20), a consolidated review, and a check run; a deterministic validator enforces exact output shapes, severity prefixes, inventory counts, and correct APPROVE/REQUEST_CHANGES conclusions based on Critical/High findings.
  • Head drift causes the agent to emit a noop instead of a review, preventing stale-commit feedback.
  • Updates sfl.json to register the sfl-pr-review component and configure an engine policy routing it to moonshotai/kimi-k3 via OpenRouter with OPENROUTER_API_KEY.
  • Bumps github/gh-aw-actions/setup to v0.84.1 in the actions lock.

Macroscope summarized 8352693.

Source: hemsoft-dev/set-it-free-loop@380fe0e
Version: 2.0.0
Tier: review
Components: labels, governance, sfl-pr-review
Engine policy: codex-gpt-55-high

See https://github.com/HemSoft/set-it-free-loop for full documentation.
@cursor

cursor Bot commented Aug 1, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added an automated, label-triggered pull request review workflow with comprehensive checks.
    • Reviews now provide severity-based inline findings and consolidated approval or change-request results.
    • Review outcomes automatically approve eligible changes or request updates for critical findings.
    • Added safeguards for stale changes, excessive findings, and incomplete review results.
  • Chores

    • Updated deployment and review configuration.
    • Updated the pinned automation action version.
    • Added a repository badge and automatic update marker to the README.

Walkthrough

Added a label-triggered pull request review workflow. It performs three review passes, validates findings and outputs, submits one consolidated review, creates one approval check, and adds deployment configuration, an action update, and an SFL badge.

Changes

SFL pull request review

Layer / File(s) Summary
Review workflow setup
.github/workflows/sfl-pr-review.md, sfl.json
Defines the trigger, permissions, model settings, credentials, safe outputs, output limits, review metadata, and restrictions on repository and pull-request modifications.
Review execution and reporting
.github/workflows/sfl-pr-review.md
Reviews the triggering pull request head, handles stale heads, validates inventory and severity data, enforces the 20-comment cap, posts findings, submits one consolidated review, and creates one approval check.
Deployment integration and repository metadata
sfl.json, .github/aw/actions-lock.json, README.md
Registers the workflow, updates the pinned setup action from v0.83.1 to v0.84.1, and adds the SFL badge.

Estimated code review effort: 4 (Complex) | ~45 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the deployment of Set it Free Loop review tier version 2.0.0.
Description check ✅ Passed The description directly explains the Set it Free Loop deployment, workflow additions, configuration changes, and verification steps.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sfl/tier-review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@macroscopeapp

macroscopeapp Bot commented Aug 1, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Unable to check for correctness in 8352693. This PR deploys a new automated PR review workflow capability that can approve or request changes on pull requests using external AI services. While the author owns all changed files, introducing new features with security implications (secret handling, external API integration, automated review actions) warrants human review.

You can customize Macroscope's approvability policy. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Aug 1, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e7b4d9d52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/sfl-pr-review.md:
- Around line 39-42: Update the review prompt and approval-policy logic in
submit-pull-request-review so unresolved Critical or High findings from
superseded reviews are carried into the current severity counts, or APPROVE is
refused while any remain unresolved. Preserve supersede-older-reviews behavior,
but ensure replacing an older REQUEST_CHANGES review cannot dismiss unresolved
blocking findings.
- Around line 36-38: Update the create-pull-request-review-comment configuration
so reaching the per-run inline-comment cap cannot omit findings while still
allowing approval: increase max sufficiently for all findings or configure
overflow to fail the check and force REQUEST_CHANGES, preserving the requirement
to emit one inline comment per finding.
- Around line 175-177: Update the final sfl-review label-removal step in the
workflow so it runs only after deterministic verification confirms the
consolidated review and check requests succeeded; otherwise retain the label for
automatic retry. Preserve the existing ordering and ensure the fallback accounts
for safe-output operations failing independently.
- Around line 77-83: Update the review workflow instructions after the three
review passes to re-read the triggering PR’s current head SHA and compare it
with `${{ github.event.pull_request.head.sha }}` before publishing comments,
approval, or labels. If they differ, fail closed without emitting outputs and
require a new workflow run; otherwise continue with the analyzed commit.

In `@README.md`:
- Line 10: Update the adjacent Set it Free Loop badge entries in README.md so
they are not visually indistinguishable: either remove the duplicate badge and
retain one destination, or give each badge distinct alt text and visible
labeling that clearly identifies its target.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 706aa752-7a06-407d-9631-c60f3806e9de

📥 Commits

Reviewing files that changed from the base of the PR and between 8e6281c and 2e7b4d9.

⛔ Files ignored due to path filters (1)
  • .github/workflows/sfl-pr-review.lock.yml is excluded by !**/*.lock.yml
📒 Files selected for processing (4)
  • .github/aw/actions-lock.json
  • .github/workflows/sfl-pr-review.md
  • README.md
  • sfl.json

Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread README.md Resolved
Source: hemsoft-dev/set-it-free-loop@235a0df
Version: 2.0.0
Tier: review
Components: labels, governance, sfl-pr-review
Engine policy: codex-gpt-55-high

See https://github.com/HemSoft/set-it-free-loop for full documentation.
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 1, 2026 22:39

Dismissing prior approval to re-evaluate dcd4dcc

Source: hemsoft-dev/set-it-free-loop@78483bb
Version: 2.0.0
Tier: review
Components: labels, governance, sfl-pr-review
Engine policy: codex-gpt-55-high

See https://github.com/HemSoft/set-it-free-loop for full documentation.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/sfl-pr-review.md:
- Line 46: Re-enable threat detection in the workflow configuration by changing
the threat-detection setting from false to true before permitting the APPROVE
event. Keep the existing allowed-events configuration unchanged.
- Around line 9-12: Update the label_command workflow to handle
workflow_dispatch runs explicitly: either add a PR-number-based path that
resolves the pull request head SHA and head branch for reviewed-HEAD,
approval-check HEAD, and SFL run values, or reject manual runs without
pull_request context before those values are used. Preserve the existing
pull_request behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e940cec8-fbf4-4a45-83c4-94b2d2f579bb

📥 Commits

Reviewing files that changed from the base of the PR and between dcd4dcc and 56a49f8.

⛔ Files ignored due to path filters (1)
  • .github/workflows/sfl-pr-review.lock.yml is excluded by !**/*.lock.yml
📒 Files selected for processing (3)
  • .github/aw/actions-lock.json
  • .github/workflows/sfl-pr-review.md
  • sfl.json

Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread .github/workflows/sfl-pr-review.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026 •

Copy link
Copy Markdown

Manual reviews triggered for commit 8352693:

All prior checks · these links stay valid even if you push more commits.

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd37c5392a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread .github/workflows/sfl-pr-review.md Resolved
HemSoft and others added 2 commits August 2, 2026 02:17
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3431d55267

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved
Comment thread .github/workflows/sfl-pr-review.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7011cccef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e0baf9221

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b38395927f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c294682bac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/sfl-pr-review.md Resolved
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@HemSoft

HemSoft commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

@macroscope-app review

@coderabbitai

coderabbitai Bot commented Aug 2, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@macroscopeapp

macroscopeapp Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review started. Approvability and Correctness checks are running—results will be posted when complete.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8352693256

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft
HemSoft merged commit 58a759c into main Aug 2, 2026
16 of 17 checks passed
@HemSoft
HemSoft deleted the sfl/tier-review branch August 15, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant