scheduler: normalize node affinity by the larger of the pos/neg weight sums - #28500
Open
larrasket wants to merge 1 commit into
Open
scheduler: normalize node affinity by the larger of the pos/neg weight sums#28500larrasket wants to merge 1 commit into
larrasket wants to merge 1 commit into
Conversation
…t sums NodeAffinityIterator normalized a node's affinity score by the sum of the absolute value of every affinity weight. When a job mixed positive and negative weights, an anti-affinity on one node inflated the denominator for an unrelated node that only matched a positive affinity (and vice versa), so the score never reached the full [-1, 1] range. For example a +100 affinity on node A plus a -100 anti-affinity on node B scored node A at 0.5 instead of 1.0. Divide by the larger of the total positive weight and the total negative weight instead. This restores the full range while still keeping every score within [-1, 1], since the matched total is bounded by the positive sum above and the negative sum below. Fixes hashicorp#11130 Signed-off-by: Saleh <root@lr0.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NodeAffinityIterator normalized a node's affinity score by the sum of the absolute value of every affinity weight. When a job mixed positive and negative weights, an anti-affinity on one node inflated the denominator for an unrelated node that only matched a positive affinity (and vice versa), the score does not reached the [-1, 1] range.
For example a +100 affinity on node A plus a -100 anti-affinity on node B scored node A at 0.5 instead of 1.0.
This divides by the larger of the total positive weight and the total negative weight instead. This restores the range while still keeping scores within [-1, 1], since the matched total is bounded by the positive sum above and the negative sum below.
Testing & Reproduction steps
Links
Fixes #11130
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.and followed the AI usage guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.