Repository navigation
Conversation
…m Highlight painting, focus routing + hijack guard
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
S1 of Cmd+F find in Preview PDFs — the vertical slice. Cmd+F on a focused PDF pane opens a find pill, highlights every match, and steps through them.
pdf-find-core.ts): walks the pdf.js text layer into a normalized searchable string + DOM offset map. Handles hyphen-line-break joins, whitespace collapse, NFKC (ligatures), per-page tagging.pdf-find-highlight.ts): CSS Custom Highlight API only — never mutates the DOM, so selection/copy/links are untouched.pdf-find-controller.ts): per-pane state, lazy index, debounced query, pane-scoped scroll (neverscrollIntoView).pdf-find-pill.tsx): floating find bar in the preview controls; exempt from idle auto-hide.pdf-find-guard.ts,session-preview-tab.tsx,entry.tsx): focus-based Cmd+F routing; a boot-time guardpreventDefaults the key inside a PDF pane so upstreamfile-find(which captures Cmd+F whenever a diff/tool card is mounted) can't hijack it —stopPropagationis never called, so the command registry still fires.Test plan
bun test src/components/session/in the app package), incl. 28 new find-core tests.Part of the "Find in Preview" design (parent issue draft in scratchpad). S2–S4 (options, recompile survival, markdown) come next.