Repository navigation
fix(ops): hub-native fleet-status collection on erlich (#1657) - #1659
Draft
aarontrowbridge wants to merge 1 commit into
Draft
aarontrowbridge wants to merge 1 commit into
aarontrowbridge wants to merge 1 commit into
Conversation
The four mini-era probes all lied on the erlich hub; each is now hub-native: this machine names itself from the fleet config's sshAlias instead of a hardcoded first entry (erlich was labeled 'mini'); the server guard reads the engine's /proc environment (pid holding OPENCODE_DB, no OPENCODE_PID) instead of launchd — the DB-channel-flip incident it exists for is caught by the pid+db check, which correctly finds the live engine; the chat DB is read via python3 against the pinned canonical name (no sqlite3 CLI on the hub); sync-log parsing is portable and reports an explicit state instead of nulls from BSD date flags. Two drive-by fixes surfaced by the verify run: the inherited ahead/behind parameter-expansion split emitted an empty token (invalid JSON) whenever a repo had a live upstream, now awk-split; the served-sessions shortfall heuristic compared a paginated, directory-filtered endpoint against a raw table count and false-alarmed the guard — served is now informational. Verified on the hub (fresh collection): erlich=this machine + both members ssh ok; guard ok with the real engine pid (matches the 4094 listener) and opencode.db; chat_db 2057 sessions = direct DB count; vault_sync explicit state; valid JSON, 57 repo rows.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1657.
Each probe rewritten hub-native, verified by running the collector on the hub against ground truth:
Two drive-by fixes the verification run exposed (both mini-era latent bugs, both noted in the commit):
Also: OUT is overridable via FLEET_STATUS_OUT for testing (used for this verification).
Deploy note: the live cadence keeps running the old script until this merges and the hub copy refreshes.