Repository navigation
Conversation
…admission (#1331) Add the shared response_presentation enum (concise|standard|detailed) to @opencode-ai/schema and admit it (optional) on the v1 session request contracts — PromptInput, ShellInput, CommandInput — so it validates at the trusted request boundary and rejects unknown values. Payloads derive from these fields, so the HTTP admission propagates automatically. Transport-only: no provider interpretation. v2 wire/persistence, server handler, and SDK regeneration follow in the same slice. Part of #1331 (parent #1330)
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded by the concise-mode skill (PR #1633). We chose a toggleable output-shaping skill over the response-presentation engine epic — it delivers 'toggle concise on/off' at a fraction of the cost with no fork expansion. The v1 enum work here isn't needed for that route. Closing unmerged; branch left for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1331 (part of #1330 — the response-presentation / "concise mode" epic). TDD, tracer-bullet by tracer-bullet.
Progress
ResponsePresentation(concise|standard|detailed) in@opencode-ai/schema, with a rejecting contract test.PromptInput,ShellInput,CommandInput; HTTP payloads derive from these, so admission propagates.coresession.promptthreadingsession_input(queue/replay parity, AC2)Protected regressions (green)
test/session/prompt.test.tstest/provider/transform.test.tsCloses #1331