Repository navigation
fleet(#1382): peer-unreachable posture — named 503, hold, no silent local - #1388
Merged
jeonghun-jj-lee merged 1 commit intoSep 21, 2026
Merged
Conversation
jeonghun-jj-lee
added
area:provisioning
afk
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
force-pushed
the
fleet/peer-unreachable-1382
branch
from
September 21, 2026 17:42
b6059e3 to
ba1ad30
Compare
jeonghun-jj-lee
marked this pull request as ready for review
September 21, 2026 17:52
jeonghun-jj-lee
force-pushed
the
fleet/peer-unreachable-1382
branch
from
September 21, 2026 17:54
096463d to
40e6a83
Compare
…ocal
- AC1: FleetPlane carries peerUnreachablePointer callback; wired through
createAmicodeService fleet options
- AC2: dispatch() peer branch returns 503 with { ok: false, error:
'attached server unreachable', reason: 'peer-unreachable', pointer }
when the attached upstream fails to serve
- AC3: the local engine is NOT silently served as a fallback — the posture
holds until explicit detach
- AC4: response shape matches the existing hub-down contract (status, ok,
error, reason, pointer)
jeonghun-jj-lee
force-pushed
the
fleet/peer-unreachable-1382
branch
from
September 21, 2026 17:55
40e6a83 to
3fd2ba9
Compare
jeonghun-jj-lee
added a commit
that referenced
this pull request
Sep 23, 2026
…ocal (#1388) - AC1: FleetPlane carries peerUnreachablePointer callback; wired through createAmicodeService fleet options - AC2: dispatch() peer branch returns 503 with { ok: false, error: 'attached server unreachable', reason: 'peer-unreachable', pointer } when the attached upstream fails to serve - AC3: the local engine is NOT silently served as a fallback — the posture holds until explicit detach - AC4: response shape matches the existing hub-down contract (status, ok, error, reason, pointer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1382 (sub-issue of #1376). Depends on #1384 (#1378).
What
When an attached peer becomes unreachable mid-session, the service returns a named 503 and holds — no silent fallback to the local engine (different DB, different sessions = dishonest).
Changes
FleetPlane.peerUnreachablePointercallback — gives the posture detector a way to surface pointer info.dispatch()peer branch — catches upstream failures and returns503 { ok: false, error: "attached server unreachable", reason: "peer-unreachable", pointer }instead of falling through.FLEET_PEER_UNREACHABLE_ERRORandFLEET_PEER_UNREACHABLE_POINTERfor external consumers (posture detector, UI).Testing
4 new tests in
fleet_client_relay.test.ts(peer-unreachable scenarios). All existing tests pass unchanged. Full suite: 6 pre-existing failures, 0 regressions.Design
AC status