Repository navigation
fleet(#1381): attach/detach upstream lifecycle + credential injection - #1387
Merged
jeonghun-jj-lee merged 2 commits intoSep 21, 2026
Merged
Conversation
jeonghun-jj-lee
added
area:provisioning
afk
jeonghun-jj-lee
added
area:provisioning
afk
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
force-pushed
the
fleet/attach-lifecycle-1381
branch
from
September 21, 2026 17:42
a7cabe8 to
4adc678
Compare
jeonghun-jj-lee
marked this pull request as ready for review
September 21, 2026 17:52
- AttachLifecycle class coordinates SSH forward bring-up, HubProxy registration on FleetPlane.attached, credential injection, and teardown on detach/re-attach - registerAttachmentRoutes wires the lifecycle into POST /attach and /detach so the pointer write drives the live transport layer - AC1: attach calls the transport factory to spin up the SSH forward - AC2: the returned HubProxy is registered on FleetPlane.attached - AC3: credential injection reads from the attachment credential store - AC4: detach stops the transport, clears the slot, resets the cursor - AC5: re-attach tears down the previous forward before starting new - 9 tests covering all 5 acceptance criteria + route-level wiring
…actory option - Add transportFactory + attachRemotePort to the fleet options in createAmicodeService so the extension activation can inject the SSH transport bring-up - Capture the FleetPlane object reference so the lifecycle can mutate its attached slot dynamically - Create the AttachLifecycle for non-client fleet machines when a transport factory is provided - Pass the lifecycle to registerAttachmentRoutes - Integration test verifies the end-to-end wiring through createAmicodeService's HTTP routes
jeonghun-jj-lee
force-pushed
the
fleet/attach-lifecycle-1381
branch
from
September 21, 2026 17:54
b505831 to
06742f6
Compare
jeonghun-jj-lee
added a commit
that referenced
this pull request
Sep 23, 2026
…#1387) * fleet(#1381): attach lifecycle coordinator + route wiring - AttachLifecycle class coordinates SSH forward bring-up, HubProxy registration on FleetPlane.attached, credential injection, and teardown on detach/re-attach - registerAttachmentRoutes wires the lifecycle into POST /attach and /detach so the pointer write drives the live transport layer - AC1: attach calls the transport factory to spin up the SSH forward - AC2: the returned HubProxy is registered on FleetPlane.attached - AC3: credential injection reads from the attachment credential store - AC4: detach stops the transport, clears the slot, resets the cursor - AC5: re-attach tears down the previous forward before starting new - 9 tests covering all 5 acceptance criteria + route-level wiring * fleet(#1381): wire lifecycle into createAmicodeService via transportFactory option - Add transportFactory + attachRemotePort to the fleet options in createAmicodeService so the extension activation can inject the SSH transport bring-up - Capture the FleetPlane object reference so the lifecycle can mutate its attached slot dynamically - Create the AttachLifecycle for non-client fleet machines when a transport factory is provided - Pass the lifecycle to registerAttachmentRoutes - Integration test verifies the end-to-end wiring through createAmicodeService's HTTP routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1381 (sub-issue of #1376). Depends on #1384 (#1378).
What
Wires the attach action to actually spin up the SSH transport, register the upstream on FleetPlane, and inject credentials — making attach a live routing change, not just a pointer flip.
Changes
AttachLifecycleclass inattach_lifecycle.ts— coordinates SSH forward bring-up (via injectableTransportFactory), HubProxy creation with credential injection, FleetPlaneattachedslot management, and teardown.registerAttachmentRoutesinvokes the lifecycle onPOST /attach(after pointer write) andPOST /detach(before pointer clear).createAmicodeServicewires the lifecycle when fleet opts includetransportFactory.Testing
10 new tests in
amicode_service_attach_lifecycle.test.tsat three levels: unit (AttachLifecycle class), route wiring, and integration. Full suite: 6 pre-existing failures, 0 regressions.AC status