Repository navigation
fix(app): keep the session view mounted across SSE loss (#1203) - #1231
Merged
Merged
Conversation
…l + honest send refusal + stale-resource read gate On stream loss the session view now STAYS MOUNTED: a reconnecting veil (v2 tokens, pointer-events none) over the last rendered timeline, cleared in place on gap-clear — no reload, no session-list refetch on the reconnect path. A send during the gap refuses honestly (toast, before history/clear) — never a fake success. The #638 staleness machine's transitions are unchanged; the render response is what changed. The session page's cached-timeline read is gated on messagesReady() so a failed refetch stops suspending the whole view.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…le check) The new session-stream-veil/stream-veil-view/stream-gap files plus the 30 changed overlay paths' hashes — the manifest is the overlay's provenance record; the drift gate catches unregistered files by design.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On stream loss the session view now STAYS MOUNTED: a reconnecting veil over the last rendered timeline (v2 tokens, pointer-events none), cleared in place on gap-clear — no reload, no refetch on the reconnect path. A send during the gap refuses honestly (toast, before history/clear). The #638 staleness machine's transitions unchanged — the render response is what changed. The session page's cached-timeline read is gated on messagesReady() so a failed refetch stops suspending the whole view.
Director gate: the slice's 22 tests green across 5 files (bun test, the materialized runner); the #638 server-sdk tests 14/14; parity 4/4. The runner's 3 lineage artifacts + 1 loader error verified pre-existing on pristine main (the runner's base diverged from dev). Fixes #1203.