Skip to content

fix(app-bundle): the overlay's rail-gate markers still match the deleted amico-run bin — post-sunset amicode shell rows may not classify #1673

Description

@aarontrowbridge

Problem

Found by the #1667 implementation (the amico-run bin deletion, PR #1672): the engine overlay's UI classification surfaces still key on the deleted bin's name —

  • packages/app-bundle/overlay/packages/ui/src/amicode/rail-gate.ts:19 — SHELL_MARKERS contains "amico-run" (while its sibling markers "amico plan" / "amico spec" never matched amico run rows either);
  • packages/app-bundle/overlay/packages/ui/src/amicode/brain-ref.ts:61 — regex /amico-run|julia/.

After the sunset, a shell row running amico run … may not be classified as amicode work by the UI rail gate — silently dropping the daily-driver path from the UI's own recognition, the exact "silent downgrade" class the campaign exists to prevent. The implementer correctly left overlay edits out of the bin-deletion slice: overlay changes require the manifest-hash refresh + materialize-path testing, a different verification discipline than the package suites.

Approach

Update the markers to the post-sunset vocabulary (amico run, alongside amico plan/amico spec/amico catalog/amico vault — enumerate what the rail gate intends to classify), refresh the overlay manifest hash per the overlay doctrine, and pin it with a test: a synthetic shell row running amico run … classifies as amicode work, and the deleted amico-run token alone no longer matches anything (the retirement is complete on both sides).

Acceptance criteria

  • Rail-gate markers classify amico run (and the intended sibling verbs) as amicode work; a test pins it.
  • The stale amico-run marker entries removed; nothing else in the marker set weakened.
  • Overlay manifest-hash refreshed + the materialize path verified per the overlay doctrine (the vendored-engine build gate green).

Prior art

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    hitlNeeds human review before merge

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions