Skip to content

fix(app): EmptyWorkspaceLanding's titlebar portals render sync-context components at the "/" route — latent crash on every real boot (origin/main) #1458

Closed

Description

@aarontrowbridge

Status: fixed in PR #1360 (d9bd9da). Filed so it's visible on main independently — this is latent on origin/main right now.

pages/empty-workspace-landing.tsx renders SessionChatsDropdown + StatusPopoverV2 into titlebar portals. StatusPopoverV2 → DirectoryStatusPopover → useSync() — but the "/" route (NewSessionLanding) is never inside a SyncProvider, so the throw kills the whole route tree. Critically, that tree ALSO contains the reactive LandingEffect — so no draft is ever created and the app stays frozen at "/".

Trigger timing: at real boot, workspace projects arrive over the wire AFTER the app mounts, so the no-directory window renders the empty landing briefly on EVERY boot — the crash is not an edge case. Unit tests (new-session-landing.test.ts etc.) mock the contexts and never see it; the e2e fleet rig caught it live.

Fix: drop the two titlebar portals from the landing (chrome dots on a momentary landing); keep the mark + open-folder content.

Activity

  1. added a commit that references this issue on Sep 23, 2026
  2. added 2 commits that reference this issue on Sep 23, 2026
  3. aarontrowbridge commented on Oct 29, 2026

    @aarontrowbridge
    MemberAuthor

    Closing as done.

    Evidence:

    Merged PR #1473 explicitly fixes #1458 by removing the empty-workspace landing's titlebar portals that crashed every real boot.

    — notturno backlog triage (amicissimo#532)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions