fleet: client roster row carries friendly name + device type (shared schema derivation) #1371

Acceptance Criteria

• @amicode/schema exports pure classifyMacModel(modelName) → laptop/desktop/undefined (rehomed from the extension's classifyDeviceType; existing behavior preserved).
• @amicode/schema exports pure classifyLinuxChassis(chassis) → laptop (laptop/notebook/portable), desktop (desktop/tower), server (server/rack), else undefined.
• @amicode/schema exports pure normalizeDeviceName(raw) proven by a table: Mac.mynetworksettings.com → Mac, host.local → host, JJ's Mac Studio → JJ's Mac Studio, "" → "". Rule: strip from the first . onward only when the remainder is a DNS-suffix-shaped label sequence; leave dot-free / space-bearing names intact.
• @amicode/schema exports pure isWslKernel(procVersion) → true on a Microsoft/WSL marker, extracted from the currently-inline regex in the extension's detectWSLVersion.
• The extension self-row imports classifyDeviceType from @amicode/schema (behavioral) and a lint/grep gate confirms no private classifier body remains in the extension (structural).
• Each node package (extension host + amico-run) exposes a single injectable command-runner seam; a per-package test feeds canned command output through the real caller into the shared pure classifier (so platform behavior is failing-test-able without shelling out).
• Linux type source order is hostnamectl chassis → /sys/class/dmi/id/chassis_type → abstain; hostnamectl absent ⇒ prettified hostname + device_type omitted.
• A client enroll POSTs a roster row whose name is the resolved friendly name and whose device_type is the resolved type.
• Resolution precedence per field, exercised by injected seams (detectDeviceType?, a setting reader): explicit setting (amicode.device.name / amicode.device.type) → OS detection → prettified hostname (name) / undefined (type). Override-wins and honest-fallback are tested independently.
• The self-row and the POSTed row resolve the same override string (both read amicode.device.name / amicode.device.type); the amicode.device.name setting description is updated to reflect it also names the fleet device.
• Wiring a friendly name does NOT change canonical.host or the minted join token (the friendly-name seam is decoupled from the canonical-host derivation).

Testing Decisions

• Extend packages/schema's roster tests with a table-driven suite for the four pure functions (Mac model strings, Linux chassis values, /proc/version WSL strings, the normalizeDeviceName table).
• Extend packages/amico-run's enroll tests (injected seams): the POSTed client row's name/device_type, override-wins, honest-fallback, and the friendly-name-does-not-touch-canonical case.
• Add a per-package impure-detector test feeding canned command output through the real command-runner seam.
• Reuse-first: extend the existing extension suite covering readLocalDevice/classifyDeviceType for the import + override-parity assertions; no new file.

Key Decisions

• Pure classification lives in @amicode/schema beside KNOWN_DEVICE_TYPES; the producer and the extension host self-row both call it. The browser sidebar module remains a third re-declaring site and cannot import schema (schema pulls node builtins).
• The impure execSync/file-read platform branch hides behind one injectable command-runner seam per package so both copies are test-covered against canned output.
• One override namespace read by both producers: amicode.device.name (existing) + new amicode.device.type.
• The friendly name never feeds canonical.host / the join token.

Constraints & Invariants

• @amicode/schema stays side-effect-free (only pure functions added; no child_process).
• No silent fallback: undetected type → server_mode fallback; no friendly-name source → prettified hostname; nothing fabricated.
• Roster JSON schema unchanged (name/device_type? already exist and validate).
• Never-fork (ADR 0005): no engine-spawn path added.

Prior Art

• The roster contract + vocabulary (RosterRow, KNOWN_DEVICE_TYPES, parseRosterRow) in the schema package.
• The client enroll path + injectable seams + settings.json reader (defaultSetTransport/defaultSettingsPath) in amico-run.
• The existing derivation (scutil ComputerName, system_profiler classifier, readLocalDevice reading amicode.device.name) in the extension; the proven WSL /proc/version regex in the rebuild host-matrix code.

Source

• Part of fleet: self-reported device identity (friendly name + device type) in the roster #1368 · durable record: ADR 0028 (docs(fleet): ADR 0028 (device identity) + ADR 0029 (unified fleet) + glossary (#1368) #1370).