-
Notifications
You must be signed in to change notification settings - Fork 172
HF-85: Implement all database functions #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
838efd1
Docs: add basic usage snippets to framework integration guides
marcin-kordas-hoc 3afa99b
Implement DCOUNT database function
marcin-kordas-hoc 6884afe
ci: retrigger
marcin-kordas-hoc f29ad00
ci: retrigger after tests PR created
marcin-kordas-hoc 007a62f
Implement DSUM, DCOUNTA, DPRODUCT database functions
marcin-kordas-hoc 2ea85fa
fixup! Implement DAVERAGE, DMAX, DMIN, DGET database functions
marcin-kordas-hoc 3ae09c8
Implement DSTDEV, DSTDEVP, DVAR, DVARP database functions
marcin-kordas-hoc 8470ad0
Implement all 12 database functions (D-functions family)
marcin-kordas-hoc 70906ef
fix: remove unnecessary type assertions in DatabasePlugin (lint)
marcin-kordas-hoc b4fe776
Docs: add Database section to built-in-functions.md and nuances to kn…
marcin-kordas-hoc e630479
refactor: extract shared boilerplate in DatabasePlugin (DRY)
marcin-kordas-hoc e8cc25c
fix: remove Excel mention from known-limitations, trailing space
marcin-kordas-hoc e9560a0
ci: retrigger after tests repo rebase
marcin-kordas-hoc 78f1daf
fix: Czech DCOUNT translation and boolean field coercion
marcin-kordas-hoc 7498108
fix: guard resolveFieldIndex against non-finite indices
marcin-kordas-hoc 96034e8
fix: propagate CellError from field and criteria arguments
marcin-kordas-hoc ad18e29
fix: Dutch DCOUNTA translation typo (DBAAANTALC -> DBAANTALC)
marcin-kordas-hoc b77c822
fix: Norwegian DCOUNT translation (ANTALLDB -> DANTALL)
marcin-kordas-hoc e599eae
fix: propagate CellError from field cells in D-function aggregations
marcin-kordas-hoc 1dd7b10
fix: propagate CellError from field cells in DCOUNT and DCOUNTA too
marcin-kordas-hoc 32ba518
fix: Polish diacritics + DGET CellError explicit guard
marcin-kordas-hoc b7a15f2
fix: correct D-function translations for cs, tr, da, pt per Microsoft…
marcin-kordas-hoc 2b08000
fix: DGET multiple-match check takes priority over field CellError
marcin-kordas-hoc 936496a
Fix: HF-85 revert framework integration guide changes (out of scope)
marcin-kordas-hoc bead1c3
Fix: HF-85 remove DGET/DMAX/DMIN/DPRODUCT bullets — these match Excel
marcin-kordas-hoc 09a0585
Fix: HF-85 Russian DCOUNTA missing yo letter
marcin-kordas-hoc 74c4397
Fix: HF-85 propagate CellError from criteria header cells
marcin-kordas-hoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finnish DCOUNTA translation has incorrect dot separator
Medium Severity
The Finnish translation for
DCOUNTAis'TLASKE.A'(with a dot), but the correct Excel Finnish function name is'TLASKEA'(without a dot). Users typing the correct Finnish name won't get the function recognized, and the registered name doesn't match Excel Desktop.Reviewed by Cursor Bugbot for commit 465321f. Configure here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
False positive — Finnish Excel uses dot syntax in function names (e.g.,
LASKE.Afor COUNTA,KESKIARVO.JOSfor AVERAGEIF,LASKE.TYHJÄTfor COUNTBLANK).TLASKE.Afor DCOUNTA is consistent with this convention and matches Microsoft's official Finnish translation. The dot is intentional, not a separator typo.