Skip to content

Describe Definition of Done for the code changes - #1642

Merged
sequba merged 2 commits into
developfrom
feature/definition-of-done
Mar 26, 2026
Merged

sequba merged 2 commits into
developfrom
feature/definition-of-done

Conversation

@sequba

@sequba sequba commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

Adding Definition of Done for the code changes to the DEV_DOCS.md


Note

Low Risk
Documentation-only change that adds contribution/process guidance; no runtime behavior or data/security impact.

Overview
Adds a new "Definition of Done" section to DEV_DOCS.md describing what production-code PRs must include before review (code changes incl. i18n packs when relevant, tests expectations for internal vs. external contributors, related docs/migration guide updates, JSDoc/technical docs, changelog entry, and PR description).

Written by Cursor Bugbot for commit 0d7351f. This will update automatically on new commits. Configure here.

@sequba sequba self-assigned this Mar 24, 2026
@github-actions

github-actions Bot commented Mar 24, 2026 •

Copy link
Copy Markdown

Performance comparison of head (0d7351f) vs base (266089d)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 501.35 | 492.18 | -1.83%
                                      Sheet B |  159.5 | 160.74 | +0.78%
                                      Sheet T | 140.27 | 138.65 | -1.15%
                                Column ranges | 468.08 | 463.48 | -0.98%
Sheet A:  change value, add/remove row/column |  15.02 |  15.58 | +3.73%
 Sheet B: change value, add/remove row/column | 131.35 | 129.64 | -1.30%
                   Column ranges - add column | 149.45 | 151.43 | +1.32%
                Column ranges - without batch | 444.64 | 445.52 | +0.20%
                        Column ranges - batch | 115.15 | 114.22 | -0.81%

@marcin-kordas-hoc

Copy link
Copy Markdown
Collaborator

Thanks! This is very helpful as a checklist.

Two things I used to forget — would it make sense to mention them here too?

  • tests go in hyperformula-tests (not the public repo)
  • i18n translations for new functions (17 language files)

Or maybe that's too specific and better left for the function implementation workflow?

@sequba

sequba commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! This is very helpful as a checklist.

Two things I used to forget — would it make sense to mention them here too?

  • tests go in hyperformula-tests (not the public repo)
  • i18n translations for new functions (17 language files)

Or maybe that's too specific and better left for the function implementation workflow?

@marcin-kordas-hoc I added these points to the list. Any other ideas?

@sequba
sequba merged commit 72db14b into develop Mar 26, 2026
32 checks passed
@sequba
sequba deleted the feature/definition-of-done branch March 26, 2026 10:16
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.18%. Comparing base (266089d) to head (0d7351f).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1642   +/-   ##
========================================
  Coverage    97.18%   97.18%           
========================================
  Files          172      172           
  Lines        14845    14845           
  Branches      3264     3264           
========================================
  Hits         14427    14427           
  Misses         418      418           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants