FALSE() and TRUE() functions aliases are missing

[wojciechczerniak]

Description

For compatibility reasons functions =TRUE() and =FALSE() should allow to leave off the parenthesis. =TRUE and =FALSE should be an alias to the corresponding function. Supported by Excel and Google Spreadsheet.

Add tests

TRUE

it('works without parenthesis', () => {
  const engine = HyperFormula.buildFromArray([['=TRUE']])

  expect(engine.getCellValue(adr('A1'))).toEqual(true)
})

FALSE

it('works without parenthesis', () => {
  const engine = HyperFormula.buildFromArray([['=FALSE']])

  expect(engine.getCellValue(adr('A1'))).toEqual(false)
})

Reference

https://support.office.com/en-us/article/true-function-7652c6e3-8987-48d0-97cd-ef223246b3fb

[wojciechczerniak]

Should be done with #27

[wojciechczerniak]

Should be possible with Named Expressions #126

    const engine = HyperFormula.buildFromArray([
      ['=TRUE()', '=TRUE', '=A1=B1'],
      ['=FALSE()', '=FALSE', '=A2=B2'],
      ['=FALSE', '=TRUE', '=A3=B3'],
    ])

    engine.addNamedExpression('TRUE', '=True()')
    engine.addNamedExpression('FALSE', '=False()')

    expect(engine.getCellValue('C1')).toEqual(true)
    expect(engine.getCellValue('C2')).toEqual(true)
    expect(engine.getCellValue('C3')).toEqual(false)

[aninde]

A dditionally after entering =true or =true()
should display TRUE
and similarly after =false() or =false should display FALSE like it is on GS.

it('6.3.14 Conversion to Text', () => {
      const engine = createEngine([
        ['="foo"&1', '="foo"&1.2', '="1232"+1', '="foo"&C1'],
        ['="foo"'],
        ['="foo"&PRAWDA()', '="foo"&TRUE()', '=FALSE()', '="foo"&C3'],
        ['="foo"', '=PRAWDA()', '=A1:B1', '=A1&C1'],
      ])
      // return number as text with no whitespace
      expect(engine.getCellValue('A1')).toBe('foo1')
      expect(engine.getCellValue('B1')).toBe('foo1.2')
      expect(engine.getCellValue('D1')).toBe('foo1233')
      // return text as text
      expect(engine.getCellValue('A2')).toBe('foo')
      // return logical as string TRUE or FALSE
      **expect(engine.getCellValue('A3')).toBe('fooTRUE')** 
      **expect(engine.getCellValue('B3')).toBe('fooTRUE')** 
      **expect(engine.getCellValue('C3')).toBe('TRUE')**
      **expect(engine.getCellValue('D3')).toBe('fooFALSE')**

    })

And beloved test from

hyperformula/test/conformance/small-group-evaluator.spec.ts

Line 178 in 0a28020

it('6.3.14 Conversion to Text', () => {

should pass, right now instead of TRUE, HyperFormula returns true and false insted of uppercase FALSE.

[wojciechczerniak]

Should work, named expressions are case insensitive and should be normalized to TRUE/FALSE when used with any other casing.

[aninde]

Unfortunately, the tests do not pass. I tried them in three versions by comparing expect with .toBe (EDITED) with changed new Config, .toEqual .toStrictEqual. Of course locally they were not pending by xdescire. I pushed them like that, due to CI. I checked versions with .toEqual and .toStrickEqual twice with different `Config.ts

export interface ConfigParams {
  caseSensitive: boolean,
...
}
export class Config {

  public static defaultConfig: ConfigParams = {
    caseSensitive: true,
... }

and

export interface ConfigParams {
  caseSensitive: boolean,
...
}
export class Config {

  public static defaultConfig: ConfigParams = {
    caseSensitive: false,
... }

EDITED:

it('simple FALSE() should return FALSE with caseSensetive', () => {
    const engine = createEngine([
      ['=FALSE()']],
    new Config({ caseSensitive: true }))
    
    expect(engine.getCellValue('A1')).toBe('FALSE')
  })

toEqual - Jest docs
toStrictEqual - Jest docs

[aninde]

I hide my comment above. What I have described should work after the implementation of Named Expressions #126.