Rework /clubs and add /teachers - #2248
Merged
Merged
Conversation
Biographier biography
Resolved the app/[locale]/clubs/page.tsx conflict by keeping our redesigned page (hero, marquee, learn-more modals, decor) and adding the minimal locale scaffold (Props/params, generateMetadata via buildPageMetadata, setRequestLocale) so it fits the new [locale] routing. Everything else came in from upstream unmodified.
# Conflicts: # app/[locale]/clubs/page.tsx # lib/botid-protected-routes.ts # lib/botid.ts # next-env.d.ts
Contributor
|
@wally-hc is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Please fix the failing checks! |
3kh0
previously approved these changes
Sep 26, 2026
Both pages had their copy hardcoded in English, so every locale showed
English. Move all copy into the Clubs and Teachers namespaces and add
translations for ru, fr, de, es and az.
- Clubs: replace the old page's unused keys with the new page's copy,
including the FAQ modal. Mirror it in namespaces/{en,ru,de}/00-core.json,
which are merged over the main files.
- Teachers: reuse the existing Parents translations for the engage
boxes, "Hack Club is:" and the hacking definition, and the old
Clubs.videoTitle.
- Signup form: translate placeholders, button and errors; show a
localized error instead of the API's English message.
- Slack stats: format numbers in the page locale instead of en-US.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3kh0
approved these changes
Sep 26, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://site-rust-rho-42.vercel.app/clubs
https://site-rust-rho-42.vercel.app/teachers