Switch e2e screenshot browser to firefox-esr - #881
Merged
Conversation
Chrome 147+ fails to produce --headless --screenshot images in the e2e container (Page.captureScreenshot regression), which made the e2e-test job exhaust its 30-min polling window and fail. Replace google-chrome-stable with firefox-esr from the Mozilla Team PPA (base image is Ubuntu 24.04 Noble). The shared browser-helpers.sh in ghcr.io/guysoft/custompios:devel now prefers firefox-esr/firefox and falls back to Chrome, so this pairs with the CustomPiOS helper update. Validated locally: firefox-esr 140.13.0esr installs and --headless --no-remote --screenshot emits a real PNG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devele2e-test (run 30759697193): Chrome 147+ no longer produces--headless --screenshotimages in the e2e container, so the screenshot retry loop consumed the 30-min job timeout.google-chrome-stablewithfirefox-esr(Mozilla Team PPA; base image is Ubuntu 24.04 Noble). Firefox's--screenshotCLI is stable and ESR pins a major version for ~12 months.ghcr.io/guysoft/custompios:devel):browser-helpers.shprefersfirefox-esr/firefoxand falls back to Chrome. Validated locally:firefox-esr 140.13.0esrinstalls and--headless --no-remote --screenshotemits a real PNG.Test plan
e2e-testjob passes: OctoPrint wizard (HTTP 200 + CONFIG_WIZARD) verified.