Skip to content
This repository was archived by the owner on Jun 15, 2021. It is now read-only.

v4.0.0 - #512

Closed
shaundillon wants to merge 8 commits into
masterfrom
v4.0.0
Closed

v4.0.0#512
shaundillon wants to merge 8 commits into
masterfrom
v4.0.0

Conversation

@shaundillon

@shaundillon shaundillon commented Aug 22, 2017 •

Copy link
Copy Markdown
Contributor

This takes some steps towards modernising scribe. We're now actively developing scribe again and these steps move some way towards making this process easier.

Major changes are:

  • Build is moved to Webpack 2 (Due to issues getting Webpack to build AMD nicely, this will be in an upcoming version in order to get this out)
  • Scripts are moved from Grunt to npm scripts
  • Scribe will now only be published on npm
  • Dependencies have been updated

@danburzo

Copy link
Copy Markdown
Contributor

Wow, this is exciting news!

@shaundillon shaundillon changed the title [WIP] - V4.0.0 [WIP] - v4.0.0 Aug 22, 2017
@shaundillon shaundillon changed the title [WIP] - v4.0.0 v4.0.0 Aug 24, 2017

@gtrufitt gtrufitt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Comment thread .tern-project
"html-janitor": "./bower_components/html-janitor/src/html-janitor",
"lodash-amd": "../bower_components/lodash-amd"
"html-janitor": "./node_modules/html-janitor/src/html-janitor",
"lodash-amd": "../node_modules/lodash-amd"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

html-janitor is ./ lodash-amd is ../ - I assume it works, but is it right?

Comment thread CHANGELOG.md Outdated
@@ -1,3 +1,11 @@
# 4.0.0

- Builds using [webpack 2](https://webpack.js.org/)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack 2

Ya sure about that? 😉 (3.5.1)

Comment thread package.json
{
"name": "scribe-editor",
"version": "3.3.0",
"version": "4.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to publish Scribe underneath https://www.npmjs.com/org/guardian now?

Comment thread webpack.conf.js Outdated
},

resolve: {
extensions: ['.js', '.jsx', '.json']

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsx?

Comment thread .babelrc Outdated
// .babelrc
{
"presets": [
["es2015"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a differnt PR when we review browser matrix but babel-preset-env instead of es2015 with the browser support?

@shaundillon shaundillon mentioned this pull request Aug 24, 2017
2 tasks
Comment thread package.json
"q": "~1.5.0",
"request": "~2.81.0",
"requirejs": "~2.1.9",
"scribe-plugin-blockquote-command": "guardian/scribe-plugin-blockquote-command#master",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you missing https://www.npmjs.com/package/scribe-common from the package.json?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope never mind

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbarton

mbarton commented Aug 15, 2018 •

Copy link
Copy Markdown

Hi all,

A year later (sorry about that!) it's worth giving an update about our plans for Scribe. Scribe is heavily used internally in our content management systems, including the main digital CMS.

We have had many requests internally to improve noting [*] in Scribe but were unable to make much progress continuing to work directly with contentEditable elements.

As such we’ve been working to move our implementation on top of Prose Mirror. The results are exciting and are setting us up for other interesting things in the future like collaborative editing.

We will do a new point release with @RichieAHBs pull request so we can continue with our migration. We will also endeavour to merge existing PRs where possible.

As our Prose Mirror based work continues, we hope to bring it together to provide a new major version of Scribe. This should maintain the “easy to embed” nature of the library whilst being a more robust platform for improvements in the future.

I hope we can share more of our plans in the coming 6 months.

[*] noting is where sub-editors will mark text so it is still visible (marked) in the CMS but does not appear in the resulting content. The nuances are many and varied and Scribes implementation relied on invisible characters which themselves sometimes lead to incorrect spacing and formatting in the resulting content.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants