node.children is undefined? #462

Activity

1. mindplay-dk commented on Mar 15, 2016

   

   mindplay-dk

   on Mar 15, 2016

   Author

   More actions

   We probably ought to have an extra function to check if a given node is an HTMLElement, and then use that to make an extra assertion before relying on children - something like:

       function isHTMLElement(node) {
           return node instanceof HTMLElement;
       }
   
       function isEmptyInlineElement(node) {
           if (isHTMLElement(node)) {
               if (node.children.length > 1) {
                   return false;
               }
               if (node.children.length === 1 && node.textContent.trim() !== '') {
                   return false;
               }
               if (node.children.length === 0) {
                   return node.textContent.trim() === '';
               }
               return isEmptyInlineElement(node.children[0]);
           }
           return false;
       }
   
2. rrees

   self-assigned this

   on Mar 23, 2016
3. rrees commented on Apr 3, 2016

   

   rrees

   on Apr 3, 2016

   Contributor

   More actions

   I agree with trying to implement the right check
4. katebee

   added

   beginner

   on Feb 3, 2017
5. katebee

   unassigned

   rrees

   on Feb 3, 2017
6. katebee

   added

   help wanted

   on Feb 3, 2017
7. katebee commented on Feb 3, 2017

   

   katebee

   on Feb 3, 2017

   Contributor

   More actions

   @rrees adding labels appears to have unassigned you 😢 (that was not intentional)