Skip to content

feat(proto-loader): support longs: BigInt for int64 fields - #3073

Open
brzosthub wants to merge 1 commit into
grpc:masterfrom
brzosthub:feat/proto-loader-bigint-longs
Open

feat(proto-loader): support longs: BigInt for int64 fields#3073
brzosthub wants to merge 1 commit into
grpc:masterfrom
brzosthub:feat/proto-loader-bigint-longs

Conversation

@brzosthub

@brzosthub brzosthub commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • Allow longs: BigInt in @grpc/proto-loader (runtime options, CLI, and proto-loader-gen-types)
  • Bump protobufjs floor to ^7.6.0 (BigInt conversion support)
  • Add a decode test for int64/uint64/sint64/fixed64/sfixed64 as native bigint

Closes #3047

Depends on protobufjs BigInt conversion from protobufjs/protobuf.js#2257 (backported in 7.6.0).

Test plan

  • npm run compile in packages/proto-loader
  • mocha build/test/**/*.js — includes new BigInt deserialize test
  • npm run validate-golden

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: brzosthub / name: Hubert Brzostowski (f3d01ba)

@brzosthub brzosthub mentioned this pull request Aug 11, 2026
Open
@brzosthub

brzosthub commented Aug 18, 2026

Copy link
Copy Markdown
Author

Hi @murgatroid99 , @wenbozhu — would one of you be able to take a look at this PR when you have a chance? It adds longs: BigInt support to @grpc/proto-loader and addresses #3047.

Thanks!

@brzosthub
feat(proto-loader): support longs: BigInt for int64 fields
e4be8ce 
Expose protobufjs BigInt conversion (available since 7.6.0) through
@grpc/proto-loader options, CLI, and generated TypeScript types.
Fixes grpc#3047.
@brzosthub
brzosthub force-pushed the feat/proto-loader-bigint-longs branch from f3d01ba to e4be8ce Compare September 22, 2026 14:59
@brzosthub

brzosthub commented Sep 22, 2026

Copy link
Copy Markdown
Author

Rebased onto master (e4be8ce). The earlier CI failure was unrelated — windows-latest
moved to CMake 4.x and broke the vendored protobuf build; fixed on master in #3076.

The new run needs approval (action_required). @murgatroid99 could you approve it and
review when you have a chance? Adds longs: BigInt to @grpc/proto-loader, fixes #3047.

@brzosthub

brzosthub commented Oct 15, 2026

Copy link
Copy Markdown
Author

@murgatroid99 friendly ping on this one. It’s a small, opt-in change (longs: BigInt) on top of protobufjs 7.6.0’s BigInt support that dcodeIO mentioned in #3047. The branch merges cleanly with current master, and none of the master commits since the base touch proto-loader. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow configuration to choose BigInt over Long.js for int64 types

1 participant

@brzosthub