Fix flaky streaming test - #2134
Merged
JamesNK merged 5 commits intoMay 25, 2023
Merged
Conversation
Member
Author
|
Please review 🙏 |
| CancellationToken.None).AsTask().DefaultTimeout(); | ||
|
|
||
| Assert.IsFalse(pickTask2.IsCompleted); | ||
| Assert.IsFalse(pickTask2.IsCompleted, "PickAsync should wait until an subchannel is ready."); |
Contributor
There was a problem hiding this comment.
I don't get it. You wait for subchannels to be ready, assert that PickAsync doesn't complete, and then say PickAsync shouldn't complete until subchannels are ready. (Also, the grammar is wrong in the sentence, I assume you mean "any subchannels are ready" or "a subchannel is ready")
Contributor
There was a problem hiding this comment.
Ah wait, now I understand, the expectedCount value is 0, maybe use named params.
BrennanConroy
approved these changes
May 24, 2023
JamesNK
commented
May 25, 2023
This was referenced Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failure noticed here - #2131 (comment)