Repository navigation
Support serde_json::Value as juniper::object::Object #504
Description
Say when writing a custom error:
#[derive(thiserror::Error, Debug, Deserialize, Serialize)]
#[serde(tag = "type", content = "data")]
enum SomeError {
#[error("SomeError Item: arg1: {arg1}, arg2: {arg2}")]
Item { arg1: String, arg2: i32 },
}I will return to the frontend as:
{
...,
"extensions": {
// this field is serialized from serde
"data": {
"arg1": "<some-arg1>",
"arg2": "<some-arg2>"
}
}
}So I write:
impl IntoFieldError for SomeError {
fn into_field_error(self) -> juniper::FieldError {
let data = serde_json::to_value(&self)
.ok()
.and_then(|j| j.get("data").cloned())
.unwrap_or_default();
juniper::FieldError::new(
self.to_string(),
juniper::Value::object(
vec![
("type", juniper::Value::scalar("SomeError")),
("data", juniper::Value::object(data.into())),
]
.into_iter()
.collect(),
),
)
}But of course, it won't compile, for:
the trait bound `juniper::Object<_>: std::convert::From<serde_json::value::Value>` is not satisfied
- I think that
serde_json::Valueandjuniper::object::Objectshould be convertable; - Maybe
HashMap<String, String>andjuniper::object::Objectshould be convertable; JSON(mapped to serde_json::Value) scalar is needed
Reacted by Andrew Banchich, Joshua Koudys, Ethan, Simon Menke, Joe Grund, Dmitriy and Barış Arıkan
Reacted by NeotenicPrimate
Activity
mwilliammyers commentedon Jan 27, 2020
I agree; I would love to see this feature behind a disabled by default feature flag.
See #325 and #280.
littledivy commentedon Jul 13, 2020
@mwilliammyers What is the status of the PR? I would love this feature.
LegNeato commentedon Oct 29, 2026
Thanks for the request! #280 tracks JSON value support, so I'm closing this as a duplicate.