Repository navigation
feat: implement on-chain collect for DIPs agreements - #1185
Merged
Merged
Conversation
Maikol
force-pushed
the
feat/dips-on-chain-collect
branch
from
April 8, 2026 13:57
dc68bb2 to
53d84e4
Compare
Maikol
force-pushed
the
feat/dips-continuous-collection
branch
from
April 10, 2026 13:23
52f343d to
e559039
Compare
Maikol
force-pushed
the
feat/dips-on-chain-collect
branch
from
April 10, 2026 13:24
53d84e4 to
bd19b24
Compare
Maikol
force-pushed
the
feat/dips-on-chain-collect
branch
from
April 22, 2026 14:28
bd19b24 to
9eb354c
Compare
MoonBoi9001
reviewed
Apr 27, 2026
|
|
||
| for (const agreement of readyAgreements) { | ||
| try { | ||
| await this.tryCollectAgreement(agreement, blockNumber, logger) |
Member
There was a problem hiding this comment.
tryCollectAgreement returns early on 'paused'/'unauthorized' without throwing, so updateAfterCollection runs as if the collect succeeded, when when no tx was actually sent.
MoonBoi9001
reviewed
Apr 27, 2026
| } catch (err) { | ||
| if (this.isDeterministicError(err)) { | ||
| const parsedError = tryParseCustomError(err) | ||
| logger.warn('Deterministic error collecting agreement, skipping', { |
Member
There was a problem hiding this comment.
Note: A deterministic revert here logs warn and skips, so the agreement is retried forever.
MoonBoi9001
reviewed
Apr 27, 2026
| const entityCounts = await this.graphNode.entityCount([deploymentId]) | ||
| const entities = entityCounts[0] | ||
|
|
||
| const recentBlock = blockNumber - 10 |
Member
There was a problem hiding this comment.
Could extract into RECENT_BLOCK_OFFSET or similar
MoonBoi9001
approved these changes
Apr 27, 2026
Maikol
force-pushed
the
feat/dips-on-chain-collect
branch
from
April 28, 2026 20:23
f792bc2 to
078630f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.