Republish as @grafana/react-data-grid from main: auto-height (#4040), a11y, npm publishing - #8
Open
fastfrwrd wants to merge 7 commits into
Open
Conversation
Re-applies Grafana's aria-hidden additions (originally on the react-18 branch) onto the current upstream tree. Skips the ResizeHandle (upstream now sets aria-hidden itself) and the removed focus-sink div; retargets the former ScrollToCell element to its useScrollToPosition successor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Rides upstream's npm/tsdown/Node-26 tooling and layers only the Grafana publishing delta on top: - Rename package to @grafana/react-data-grid, add publishConfig, and point homepage/bugs/repository at the Grafana fork. - Add a version-gated publish job to ci.yml that auto-publishes to npm via trusted publishing on pushes to main when package.json version changes (EndBug/version-check), then tags and creates a release. - Remove Comcast-specific tooling that should not run in the fork: the gh-pages deploy step (hardcoded Comcast repo URL), publish.yml, and update-screenshots.yml. - Assign CODEOWNERS to dataviz-squad and note the fork in the README. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #7 (upstream sync). Base auto-retargets to
mainonce #7 merges and its branch is deleted. This PR is the 7 Grafana commits we layer on top of upstream.Changes
Auto-height (upstream PR Comcast#4040 re-layered) — dynamic row heights for non-virtualized rendering:
rowHeightaccepts a string (e.g."auto") with discriminated-union typing, plus PageUp/PageDown paging. Includestest/browser/rowHeight.test.tsxand theDynamicHeightCellswebsite example. This is what Grafana's Table panel relies on.Accessibility —
aria-hiddenon non-interactive utility elements (drag handle, drag image, measuring cells, scroll-to-position element). Upstream already covers the resize handle and removed the old focus-sink, so those hunks are dropped.Publish
@grafana/react-data-gridfrommain(rides upstream's npm/tsdown/Node-26 tooling):@grafana/react-data-grid,publishConfig.access: public, version7.0.0-beta.59, repo/homepage/bugs → Grafana fork.ci.yml: version-gated auto-publish job (EndBug/version-check) → npm trusted publishing on push tomainwhen the version changes, then tag + GitHub release.publish.yml,update-screenshots.yml, and thegh-pagesdeploy step (hardcoded Comcast repo URL).Verified locally
node --run typecheck✓node --run build✓ (auto-height present inlib/)routeTree.gen.tsregenerated (CI check passes)Publishing note
Merging to
main(after #7) auto-publishes7.0.0-beta.59. npm trusted-publisher config must point at this repo'sci.ymlworkflow.