Skip to content

fix(ci): derive requested teams from CODEOWNERS and detect existing PR assignees in assign-reviewers - #9703

Merged
shivanee-p merged 4 commits into
mainfrom
shivaneep-assign-reviewers-fix
Oct 23, 2026
Merged

shivanee-p merged 4 commits into
mainfrom
shivaneep-assign-reviewers-fix

Conversation

@shivanee-p

Copy link
Copy Markdown
Contributor

Fixes reviewer auto-assignment in .github/workflows/assign-reviewers.yml without requiring organization team token permissions:

Fixes

  • Add @quirogas to # team_members:.
  • Parse file-to-team rules directly from .github/CODEOWNERS instead of pulls.listRequestedReviewers (which returns teams: [] under GITHUB_TOKEN and previously caused hasDefaultTeam to evaluate to false, skipping removal of cloud-sdk-nodejs-team).
  • Check human requested_reviewers, assignees, and reviews (hasHumanReviewerOrAssignee), and trigger on review_requested and assigned events so cloud-sdk-nodejs-team is reliably removed whenever another reviewer is assigned.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file to add @quirogas to the list of team members in the comment section. There are no review comments, and I have no feedback to provide.

@shivanee-p
shivanee-p marked this pull request as ready for review October 23, 2026 03:18
@shivanee-p
shivanee-p requested a review from a team as a code owner October 23, 2026 03:18
@github-actions
github-actions Bot requested a review from feywind October 23, 2026 03:19
@shivanee-p
shivanee-p enabled auto-merge (squash) October 23, 2026 17:14
@shivanee-p
shivanee-p merged commit c82df08 into main Oct 23, 2026
46 checks passed
@shivanee-p
shivanee-p deleted the shivaneep-assign-reviewers-fix branch October 23, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants