Skip to content

fix(generator): compile protos before running tests in generator-tests #9701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quirogas merged 2 commits into from
Oct 23, 2026
Merged

fix(generator): compile protos before running tests in generator-tests #9701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ea9e9a
ci(generator): compile protos before running tests in generator-tests
shivanee-p Oct 23, 2026
9fa226f
fix(generator): guard postpack minifyProtoJson with legacyProtoLoad c…
shivanee-p Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/generator-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
presubmit:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
timeout-minutes: 45
container: gcr.io/gapic-images/googleapis:20250404
steps:
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
Expand Down Expand Up @@ -72,7 +73,7 @@ jobs:
working-directory: core/generator/gapic-generator-typescript
run: |
mkdir -p ~/artifacts
zip -r ~/artifacts/outputs.zip .test-out-*
zip -qr ~/artifacts/outputs.zip .test-out-*
tar cfz ~/artifacts/node_modules.tar.gz node_modules

- name: Save artifacts
Expand All @@ -88,17 +89,18 @@ jobs:
set -ex
cp ../../../.mocharc.cjs .
cp -r ../../../bin .
unzip ~/artifacts/outputs.zip -d library
unzip -q ~/artifacts/outputs.zip -d library
FAIL=0
PIDS=()
for lib in showcase kms translate monitoring dlp texttospeech showcase-legacy compute logging bigquery-v2 redis retail; do
(
set -ex
echo "--- Testing library $lib ---"
cd "library/.test-out-$lib"
pnpm install --no-frozen-lockfile --ignore-workspace --silent
pnpm test
pnpm install --ignore-scripts --no-frozen-lockfile --ignore-workspace --reporter=append-only < /dev/null
pnpm run compile-protos
pnpm run compile
pnpm test
pnpm run system-test
) &
PIDS+=($!)
Expand Down Expand Up @@ -131,9 +133,10 @@ jobs:
set -ex
echo "--- Testing ESM library $lib ---"
cd "library/.test-out-$lib-esm"
pnpm install --no-frozen-lockfile --ignore-workspace --silent
pnpm test
pnpm install --ignore-scripts --no-frozen-lockfile --ignore-workspace --reporter=append-only < /dev/null
pnpm run compile-protos
pnpm run compile
pnpm test
pnpm run system-test
) &
PIDS+=($!)
Expand Down
1 change: 0 additions & 1 deletion core/generator/gapic-generator-typescript/baselines/showcase-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"docs": "jsdoc -c .jsdoc.js",
"fix": "gts fix",
"lint": "gts check",
"postpack": "minifyProtoJson",
"prepare": "npm run compile",
"system-test": "node ../../bin/run-test.cjs --config ../../.mocharc.cjs --no-parallel build/system-test",
"test": "node ../../bin/run-test.cjs --config ../../.mocharc.cjs build/test"
Expand Down
4 changes: 2 additions & 2 deletions core/generator/gapic-generator-typescript/templates/cjs/typescript_gapic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
"docs": "jsdoc -c .jsdoc.js",
"fix": "gts fix",
"lint": "gts check",
"postpack": "minifyProtoJson",
"prepare": "npm run compile",
{% if not api.legacyProtoLoad %}"postpack": "minifyProtoJson",
{% endif %}"prepare": "npm run compile",
"system-test": "node ../../bin/run-test.cjs --config ../../.mocharc.cjs --no-parallel build/system-test",
"test": "node ../../bin/run-test.cjs --config ../../.mocharc.cjs build/test"
},
Expand Down
Loading